Re: [Django] #11974: Submit_row in admin doesn't follow the pattern of using admin/app_label/model/submit_line.html
Django
admin/app_label/model/submit_line.html
-------------------------------------+-------------------------------------
Reporter: vbmendes | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: | Keywords: django admin
Resolution: | templates
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by Andy Baker <andy@…>):
* cc: andy@… (added)
* needs_docs: 1 => 0
* ui_ux: => 0
* needs_tests: 1 => 0
Comment:
I am fairly sure it doesn't need tests or docs on the grounds that:
1. We haven't documented the template structure of many similar parts of
the admin
2. We don't have specific tests for the template structure of other parts
of the admin.
--
Ticket URL: <https://code.djangoproject.com/ticket/11974#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
admin/app_label/model/submit_line.html
-------------------------------------+-------------------------------------
Reporter: vbmendes | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: | Keywords: django admin
Resolution: | templates
Triage Stage: Accepted | Has patch: 1
Patch needs improvement: 1 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by jezdez):
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
* needs_docs: 0 => 1
Comment:
In fact there are several tests for using custom templates (e.g.
source:django/trunk/tests/regressiontests/admin_views/tests.py?rev=16498#L608),
so this definitely needs to be tested and documented as part of the
"Overriding admin templates" docs
(https://docs.djangoproject.com/en/dev//ref/contrib/admin/#overriding-
admin-templates).
--
Ticket URL: <https://code.djangoproject.com/ticket/11974#comment:9>
Django
admin/app_label/model/submit_line.html
-------------------------------------+-------------------------------------
Reporter: vbmendes | Owner: nobody
Component: contrib.admin | Version:
Severity: Normal | Resolution:
Keywords: django admin | Triage Stage: Accepted
templates | Needs documentation: 1
Has patch: 1 | Patch needs improvement: 1
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by jgbreezer):
* cc: jgbreezer@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/11974#comment:10>
Django
admin/app_label/model/submit_line.html
-------------------------------------+-------------------------------------
Reporter: vbmendes | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version:
Severity: Normal | Resolution:
Keywords: django admin | Triage Stage: Accepted
templates |
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: raffaele.salmaso+djangoproject@… (added)
* needs_tests: 1 => 0
Comment:
Added a PR => https://github.com/django/django/pull/7782
Hi, I've usually customize the submit row of many models in my admin.
At first I've used a similar strategy from the former patch (using
render_to_string), but while working with my setup (only one admin.site),
half of admin_views tests were broken. So this is why I used the
InclusionNode for SubmitRowNode parent class.
Additionally I've added a { block submit-row %}{% endblock %} in default
submit_line.html.
--
Ticket URL: <https://code.djangoproject.com/ticket/11974#comment:11>
Django
admin/app_label/model/submit_line.html
-------------------------------------+-------------------------------------
Reporter: vbmendes | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version:
Severity: Normal | Resolution:
Keywords: django admin | Triage Stage: Accepted
templates |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
* needs_docs: 1 => 0
Comment:
Don't forget to uncheck the "needs improvement" flags on the ticket, else
it won't appear in the review queue.
--
Ticket URL: <https://code.djangoproject.com/ticket/11974#comment:12>
Django
admin/app_label/model/submit_line.html
-------------------------------------+-------------------------------------
Reporter: vbmendes | Owner: nobody
Component: contrib.admin | Version:
Severity: Normal | Resolution: fixed
Keywords: django admin | Triage Stage: Accepted
templates |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
--
Ticket URL: <https://code.djangoproject.com/ticket/11974#comment:13>
Django
admin/app_label/model/submit_line.html
-------------------------------------+-------------------------------------
Reporter: vbmendes | Owner: nobody
Component: contrib.admin | Version:
Severity: Normal | Resolution:
templates |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Raffaele Salmaso):
* status: closed => new
* resolution: fixed =>
Comment:
(bad action)
--
Ticket URL: <https://code.djangoproject.com/ticket/11974#comment:14>
Django
admin/app_label/model/submit_line.html
-------------------------------------+-------------------------------------
| Salmaso
Type: New feature | Status: assigned
Component: contrib.admin | Version:
Severity: Normal | Resolution:
Keywords: django admin | Triage Stage: Accepted
templates |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Raffaele Salmaso):
* status: new => assigned
* owner: nobody => Raffaele Salmaso
--
Ticket URL: <https://code.djangoproject.com/ticket/11974#comment:13>
Django
admin/app_label/model/submit_line.html
-------------------------------------+-------------------------------------
Reporter: vbmendes | Owner: Raffaele
| Salmaso
Type: New feature | Status: assigned
Component: contrib.admin | Version:
Severity: Normal | Resolution:
Keywords: django admin | Triage Stage: Accepted
templates |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 1 => 0
Comment:
PR for this was closed but this should be resolved with #27728.
--
Ticket URL: <https://code.djangoproject.com/ticket/11974#comment:14>
Django
admin/app_label/model/submit_line.html
-------------------------------------+-------------------------------------
Reporter: vbmendes | Owner: Raffaele
| Salmaso
Component: contrib.admin | Version:
Severity: Normal | Resolution: fixed
Keywords: django admin | Triage Stage: Accepted
templates |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* status: assigned => closed
* resolution: => fixed
Comment:
This was resolved by #27728, which allowed overriding admin templatetag's
templates.
--
Ticket URL: <https://code.djangoproject.com/ticket/11974#comment:15>