[Django] #31588: Unclear behaviour for ModelForms

4 views
Skip to first unread message

Django

unread,
May 14, 2020, 12:19:25 PM5/14/20
to django-...@googlegroups.com
#31588: Unclear behaviour for ModelForms
------------------------------------------------+------------------------
Reporter: Vladislav | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms | Version: 3.0
Severity: Normal | Keywords: forms
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
I think it's very often task to add nessasary info to ModelForm before
.save() and i suppose this must have official decision, not this
workaround like answers in ticket:

https://stackoverflow.com/questions/17126983/add-data-to-modelform-object-
before-saving

--
Ticket URL: <https://code.djangoproject.com/ticket/31588>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 14, 2020, 2:13:07 PM5/14/20
to django-...@googlegroups.com
#31588: Unclear behaviour for ModelForms
-------------------------------------+-------------------------------------
Reporter: Vladislav | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Forms | Version: 3.0
Severity: Normal | Resolution: invalid

Keywords: forms | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* status: new => closed
* resolution: => invalid


Comment:

Hi. Thanks for the report.

The ''official decision'', the recommended way of doing it is to call
`save()` with `commit=False`, then make your modifications before saving
the instance finally.
This is documented in
[https://docs.djangoproject.com/en/3.0/topics/forms/modelforms/#the-save-
method the save method docs]. See the example there of modifying an author
in this way.

--
Ticket URL: <https://code.djangoproject.com/ticket/31588#comment:1>

Reply all
Reply to author
Forward
0 new messages