[Django] #24301: Add missing aggregate functions for contrib.postgres
Django
----------------------------------+--------------------
Reporter: coldmind | Owner:
Type: New feature | Status: new
Component: contrib.postgres | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------
Since django has `contrib.postgres` package, it will be useful to add some
postgres-specific aggregate functions, here is a list of them:
http://www.postgresql.org/docs/9.4/static/functions-aggregate.html
--
Ticket URL: <https://code.djangoproject.com/ticket/24301>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: coldmind | Owner: coldmind
Type: New feature | Status: assigned
Component: contrib.postgres | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by coldmind):
* status: new => assigned
* cc: sokandpal@… (added)
* needs_better_patch: => 0
* needs_tests: => 0
* owner: => coldmind
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/24301#comment:1>
Django
Reporter: coldmind | Owner: coldmind
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/24301#comment:2>
Django
Reporter: coldmind | Owner: coldmind
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by coldmind):
I'm working on ticket in this branch:
https://github.com/coldmind/django/compare/postresql_aggregate_functions
Some early feedback will be appreciated.
--
Ticket URL: <https://code.djangoproject.com/ticket/24301#comment:3>
Django
Reporter: coldmind | Owner: coldmind
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by charettes):
I think the best way to get early feedback would be to open a PR against
Django master since the comments on the changes will be aggregated and
persisted through rebases.
--
Ticket URL: <https://code.djangoproject.com/ticket/24301#comment:4>
Django
Reporter: coldmind | Owner: coldmind
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by coldmind):
Initial PR:
https://github.com/django/django/pull/4105
--
Ticket URL: <https://code.djangoproject.com/ticket/24301#comment:5>
Django
Reporter: coldmind | Owner: coldmind
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by coldmind):
* has_patch: 0 => 1
Comment:
Need to final review
--
Ticket URL: <https://code.djangoproject.com/ticket/24301#comment:6>
Django
Reporter: coldmind | Owner: coldmind
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
Comment:
Reviewed PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/24301#comment:7>
Django
Reporter: coldmind | Owner: coldmind
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by coldmind):
* needs_better_patch: 1 => 0
Comment:
Fixed comments in PR, also added release notes.
--
Ticket URL: <https://code.djangoproject.com/ticket/24301#comment:8>
Django
Reporter: coldmind | Owner: coldmind
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
Comment:
Did one more round of review. Should be ready for checkin after that.
--
Ticket URL: <https://code.djangoproject.com/ticket/24301#comment:9>
Django
Reporter: coldmind | Owner: coldmind
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by coldmind):
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
Comment:
Fixed last comments
--
Ticket URL: <https://code.djangoproject.com/ticket/24301#comment:10>
Django
Reporter: coldmind | Owner: coldmind
Component: contrib.postgres | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"e4cf8c8420634d6f2dc8ce873246256ce635972d" e4cf8c8]:
{{{
#!CommitTicketReference repository=""
revision="e4cf8c8420634d6f2dc8ce873246256ce635972d"
Fixed #24301 -- Added PostgreSQL-specific aggregate functions
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24301#comment:11>