[Django] #18349: Add ipv6 support to django.contrib.gis.geoip
Django
-----------------------------+--------------------
Reporter: j@… | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
-----------------------------+--------------------
libgeoip has support for ipv6 lookups
(http://geolite.maxmind.com/download/geoip/database/GeoLiteCityv6-beta/)
attached patch exposes that functionality and uses it for ipv6 addresses.
--
Ticket URL: <https://code.djangoproject.com/ticket/18349>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Type: New feature | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by jezdez):
* needs_docs: => 0
* needs_better_patch: => 1
* needs_tests: => 0
* stage: Unreviewed => Accepted
Comment:
Accepting in general,
--
Ticket URL: <https://code.djangoproject.com/ticket/18349#comment:1>
Django
Reporter: j@… | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by fcurella):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/18349#comment:2>
Django
Reporter: j@… | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by MRigal):
Updated patch to 1.6+ removed one previous unused test also. Tested and
works under 2.X and 3.X
https://github.com/django/django/pull/1986
--
Ticket URL: <https://code.djangoproject.com/ticket/18349#comment:3>
Django
Reporter: j@… | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timo):
* needs_better_patch: 0 => 1
Comment:
I left comments for improvement on PR. Please uncheck "Patch needs
improvement" when you update it, thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/18349#comment:4>
Django
Reporter: j@… | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by MRigal):
* needs_better_patch: 1 => 0
Comment:
Rebased and tried to fulfil the comments:
https://github.com/django/django/pull/5046
I didn't put too much effort in new functionalities, as this is wrapping
the legacy GeoIP databases and it should anyway be somewhen rewritten to
use the geoip2 python library. But this is out-of-scope here and would
deserve a new separate ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/18349#comment:5>
Django
Reporter: j@… | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by timgraham):
Created #25184 to add support for GeoLite2. Any objection to closing this
as "won't fix" and focusing our efforts on that ticket? I'd think once we
support the new format, we could deprecate support for the legacy format
anyway.
--
Ticket URL: <https://code.djangoproject.com/ticket/18349#comment:6>
Django
Reporter: j@… | Owner: nobody
Type: New feature | Status: closed
Component: GIS | Version: master
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by timgraham):
* status: new => closed
* resolution: => wontfix
--
Ticket URL: <https://code.djangoproject.com/ticket/18349#comment:7>