[Django] #27102: simplify_regex is not cleaning up any outstanding regex-y character

49 views
Skip to first unread message

Django

unread,
Aug 22, 2016, 2:23:09 AM8/22/16
to django-...@googlegroups.com
#27102: simplify_regex is not cleaning up any outstanding regex-y character
-----------------------------------+--------------------
Reporter: prajjwol | Owner: nobody
Type: Bug | Status: new
Component: contrib.admindocs | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------
If you try cleaning up a regex pattern involving groups, simplify_regex
fails to remove a bracket.

Steps to reproduce:
run this in your shell:
`django.contrib.admindocs.views.simplify_regex('^orgs/(?P<org_id>([0-9a-f]{32}|[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}))$')`
output:
`'/orgs/<org_id>)'`

expected output:
`'/orgs/<org_id>'`

--
Ticket URL: <https://code.djangoproject.com/ticket/27102>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 22, 2016, 2:26:38 AM8/22/16
to django-...@googlegroups.com
#27102: simplify_regex is not cleaning up any outstanding regex-y character
-----------------------------------+--------------------------------------
Reporter: prajjwol | Owner: prajjwol
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Changes (by prajjwol):

* owner: nobody => prajjwol
* needs_docs: => 0
* status: new => assigned
* needs_tests: => 0
* needs_better_patch: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/27102#comment:1>

Django

unread,
Aug 22, 2016, 3:47:06 AM8/22/16
to django-...@googlegroups.com
#27102: simplify_regex is not cleaning up any outstanding regex-y character
-----------------------------------+------------------------------------

Reporter: prajjwol | Owner: prajjwol
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by claudep):

* version: 1.8 => master
* needs_tests: 0 => 1
* stage: Unreviewed => Accepted


Comment:

[https://github.com/django/django/pull/7135 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/27102#comment:2>

Django

unread,
Aug 22, 2016, 8:50:40 AM8/22/16
to django-...@googlegroups.com
#27102: simplify_regex is not cleaning up any outstanding regex-y character
-----------------------------------+------------------------------------
Reporter: prajjwol | Owner: prajjwol
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by timgraham):

* needs_tests: 1 => 0


Comment:

The test in the pull request is fixed by the PR for #26621 so this ticket
might be considered a duplicate.

--
Ticket URL: <https://code.djangoproject.com/ticket/27102#comment:3>

Django

unread,
Aug 22, 2016, 2:59:02 PM8/22/16
to django-...@googlegroups.com
#27102: simplify_regex is not cleaning up any outstanding regex-y character
-----------------------------------+------------------------------------
Reporter: prajjwol | Owner: prajjwol
Type: Bug | Status: closed
Component: contrib.admindocs | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by prajjwol):

* status: assigned => closed
* resolution: => fixed


--
Ticket URL: <https://code.djangoproject.com/ticket/27102#comment:4>

Django

unread,
Sep 27, 2016, 7:01:10 PM9/27/16
to django-...@googlegroups.com
#27102: simplify_regex is not cleaning up any outstanding regex-y character
-------------------------------------+-------------------------------------
Reporter: Prajjwol Gautam | Owner: Prajjwol
| Gautam

Type: Bug | Status: closed
Component: contrib.admindocs | Version: master
Severity: Normal | Resolution: duplicate

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* resolution: fixed => duplicate


--
Ticket URL: <https://code.djangoproject.com/ticket/27102#comment:5>

Reply all
Reply to author
Forward
0 new messages