[Django] #28719: Better exception message when get_queryset returns None
Django
---------------------------------------------+------------------------
Reporter: Bjorn Kristinsson | Owner: nobody
Type: Bug | Status: new
Component: Generic views | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
---------------------------------------------+------------------------
One of my `ListViews` suddenly started raising `TemplateDoesNotExist` with
a rather cryptic (to me) message:
{{{
Template-loader postmortem
Django tried loading these templates, in this order:
Using engine :
This engine did not provide a list of tried templates.
}}}
It took me a while to realise this was because my get_queryset wasn't
returning anything. It did some filtering based on user settings, and I
didn't have a fallback for when none of the filtering steps applied.
Thought it might be helpful to have a better message is no template names
are found and `object_list` is `None`. Suggesting: "Expected a queryset,
but found None. Please check that <cls>.get_queryset() returns a
queryset." Pull request coming up.
--
Ticket URL: <https://code.djangoproject.com/ticket/28719>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Bjorn Kristinsson | Owner: Bjorn
| Kristinsson
Type: Bug | Status: assigned
Component: Generic views | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Bjorn Kristinsson):
* owner: nobody => Bjorn Kristinsson
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/28719#comment:1>
Django
Reporter: Bjorn Kristinsson | Owner: (none)
Type: Bug | Status: new
Component: Generic views | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Bjorn Kristinsson):
* status: assigned => new
* owner: Bjorn Kristinsson => (none)
Comment:
Created a pull request, https://github.com/django/django/pull/9255, not
entirely sure why the tests are failing.
--
Ticket URL: <https://code.djangoproject.com/ticket/28719#comment:2>
Django
Reporter: Bjorn Kristinsson | Owner: yauneyz
Type: Bug | Status: assigned
Component: Generic views | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by yauneyz):
* owner: (none) => yauneyz
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/28719#comment:3>
Django
Reporter: Bjorn Kristinsson | Owner: (none)
Type: Bug | Status: new
Component: Generic views | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Zac Yauney):
* owner: Zac Yauney => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/28719#comment:4>
Django
Reporter: Bjorn Kristinsson | Owner: (none)
Cleanup/optimization |
Component: Generic views | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Bjorn Kristinsson):
* type: Bug => Cleanup/optimization
--
Ticket URL: <https://code.djangoproject.com/ticket/28719#comment:3>
Django
Reporter: Bjorn Kristinsson | Owner: Bjorn
Type: | Kristinsson
Cleanup/optimization | Status: assigned
Component: Generic views | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Bjorn Kristinsson):
* owner: (none) => Bjorn Kristinsson
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/28719#comment:4>
Django
Reporter: Bjorn Kristinsson | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Bjorn Kristinsson):
* cc: Bjorn Kristinsson (added)
* status: assigned => new
* owner: Bjorn Kristinsson => (none)
Comment:
Oki, guess someone else than me needs to move this forward. The PR is
passing tests now, comments addressed - but someone else needs to accept
or reject it.
--
Ticket URL: <https://code.djangoproject.com/ticket/28719#comment:5>
Django
Reporter: Bjorn Kristinsson | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by hpfn):
* cc: hpfn (added)
Comment:
Hi,
I read the patch and ran the tests.
Ran 202 tests in 3.730s
OK
It seems that the patch does what the author wants. If
there is no information at all raise 'ImproperlyConfigured'.
patch ok
tests ok
docs ok
I am not changing to 'Ready for checkin' because this is
my first time doing a review.
Regards,
Herbert
--
Ticket URL: <https://code.djangoproject.com/ticket/28719#comment:6>
Django
Reporter: Bjorn Kristinsson | Owner: Tomer
Type: | Chachamu
Cleanup/optimization | Status: assigned
Component: Generic views | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tomer Chachamu):
* owner: (none) => Tomer Chachamu
* status: new => assigned
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/28719#comment:7>
Django
Reporter: Bjorn Kristinsson | Owner: (none)
Component: Generic views | Version: master
Keywords: | Triage Stage: Accepted
Easy pickings: 1 | UI/UX: 0
Changes (by Tomer Chachamu):
* owner: Tomer Chachamu => (none)
* needs_better_patch: 0 => 1
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/28719#comment:8>
Django
Reporter: Bjorn Kristinsson | Owner: (none)
Component: Generic views | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Bjorn Kristinsson):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/28719#comment:9>
Django
Reporter: Bjorn Kristinsson | Owner: (none)
Cleanup/optimization |
Component: Generic views | Version: master
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tomer Chachamu):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/28719#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Bjorn Kristinsson | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--
Ticket URL: <https://code.djangoproject.com/ticket/28719#comment:11>
Django
-------------------------------------+-------------------------------------
Type: | Graham <timograham@…>
Cleanup/optimization | Status: closed
Component: Generic views | Version: master
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* owner: (none) => Tim Graham <timograham@…>
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"ac6a4eb9f95138628a7eec76bee91eb067af80a9" ac6a4eb]:
{{{
#!CommitTicketReference repository=""
revision="ac6a4eb9f95138628a7eec76bee91eb067af80a9"
Fixed #28719 -- Added a helpful exception if
MultipleObjectTemplateResponseMixin doesn't generate any template names.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28719#comment:12>