[Django] #17215: runtests doesn't clean up all temp files all the time
Django
---------------------------------------------+------------------------
Reporter: kmtracey | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version:
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------------+------------------------
http://ci.djangoproject.com/job/Django/ builds started failing yesterday
due to too many files in /tmp:
http://ci.djangoproject.com/job/Django/461/database=sqlite3,python=python2.5/console
There were nearly 300 /tmp/django_<random> directories that had
accumulated, and looking at my own machine's tmp directory I see a bunch
of other /tmp/tmp<random> directories that have accumulated in just the
last day.
--
Ticket URL: <https://code.djangoproject.com/ticket/17215>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Type: Bug | Status: new
Component: Testing framework | Version:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by aaugustin):
* stage: Unreviewed => Accepted
Comment:
I cleaned /tmp on the CI server, but that bug should be fixed nonetheless.
--
Ticket URL: <https://code.djangoproject.com/ticket/17215#comment:1>
Django
Type: Bug | Status: new
Component: Testing framework | Version:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by kmtracey):
Replying to [comment:1 aaugustin]:
> I cleaned /tmp on the CI server, but that bug should be fixed
nonetheless.
Thanks! And oh yes we should fix the tests to not require periodic /tmp
cleanup.
It seems a clean test run leaves behind 47 (!) /tmp/tmp<random>
directories. 47*15 configs on the ci server is 705 directories
accumulating per commit. That means less than 50 commits before we again
hit the 32,000 file in the directory limit....
--
Ticket URL: <https://code.djangoproject.com/ticket/17215#comment:2>
Django
Reporter: kmtracey | Owner: kmtracey
Component: Testing framework | Version:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by kmtracey):
* owner: nobody => kmtracey
--
Ticket URL: <https://code.djangoproject.com/ticket/17215#comment:3>
Django
Reporter: kmtracey | Owner: kmtracey
Component: Testing framework | Version:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by kmtracey):
In [17094]:
{{{
#!CommitTicketReference repository="" revision="17094"
Refs #17215: Avoid generating 47 leftover tmp dirs during a clean test
run.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17215#comment:4>
Django
Type: Bug | Status: new
Component: Testing framework | Version:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by kmtracey):
* owner: kmtracey => nobody
Comment:
r17094 was a quick way to get rid of the leftover tmp dirs from a clean
test run; if anyone has a better approach/idea please speak up.
There were also some leftover django<random> dirs -- these I think come
from runs that don't complete successfully. I'm not sure how to approach
cleaning them up.
--
Ticket URL: <https://code.djangoproject.com/ticket/17215#comment:5>
Django
Reporter: kmtracey | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by aaugustin):
#19206 was a duplicate.
--
Ticket URL: <https://code.djangoproject.com/ticket/17215#comment:6>
Django
Reporter: kmtracey | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"1d9596025e53a33763d9dbb61e7dda015ec60b25"]:
{{{
#!CommitTicketReference repository=""
revision="1d9596025e53a33763d9dbb61e7dda015ec60b25"
Ensured cache tests do not leak temp dirs
Refs #17215.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17215#comment:7>
Django
Reporter: kmtracey | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"6015083e9d156e30c8cd5e200317f4c0f10f4abf"]:
{{{
#!CommitTicketReference repository=""
revision="6015083e9d156e30c8cd5e200317f4c0f10f4abf"
[1.7.x] Ensured cache tests do not leak temp dirs
Refs #17215.
Backport of 1d9596025e from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17215#comment:8>
Django
Reporter: kmtracey | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"809362518d6dbb7ca989b32ed97b39f6156563b9"]:
{{{
#!CommitTicketReference repository=""
revision="809362518d6dbb7ca989b32ed97b39f6156563b9"
Created import-time test temp dirs in known location
Refs #17215. In the same spirit as 5de31cb8cb.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17215#comment:9>
Django
Reporter: kmtracey | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"3619518c9bb8483ed911e987554ee5ae599f78d3"]:
{{{
#!CommitTicketReference repository=""
revision="3619518c9bb8483ed911e987554ee5ae599f78d3"
[1.7.x] Created import-time test temp dirs in known location
Refs #17215. In the same spirit as 5de31cb8cb.
Backport of 809362518d from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17215#comment:10>
Django
Reporter: kmtracey | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"c38e47bec02d67fe9497fb384fafb5f2806cff0b"]:
{{{
#!CommitTicketReference repository=""
revision="c38e47bec02d67fe9497fb384fafb5f2806cff0b"
[1.6.x] Created import-time test temp dirs in known location
Refs #17215. In the same spirit as 5de31cb8cb.
Backport of 809362518d from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17215#comment:11>
Django
Reporter: kmtracey | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by claudep):
We shouldn't get any more leaking temporary directories from the test
suite (running without failures or soft-interrupted by Ctrl-C), but this
needs to be confirmed. And of course, testing that any failure in one of
the ~7000 current tests don't leak directories is quite impossible.
--
Ticket URL: <https://code.djangoproject.com/ticket/17215#comment:12>
Django
Reporter: kmtracey | Owner: nobody
Type: Bug | Status: closed
Component: Testing framework | Version:
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* status: new => closed
* resolution: => fixed
Comment:
`/tmp` on the CI servers has stayed clean for some time.
--
Ticket URL: <https://code.djangoproject.com/ticket/17215#comment:13>
Django
Reporter: kmtracey | Owner: nobody
Type: Bug | Status: closed
Component: Testing framework | Version:
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by aaugustin):
I should have closed this bug with
934400759de817471ff37d736686201d7ae34e82.
--
Ticket URL: <https://code.djangoproject.com/ticket/17215#comment:14>