[Django] #27868: makemessages creates files in '__pycache__' directory by default

23 views
Skip to first unread message

Django

unread,
Feb 21, 2017, 4:23:34 PM2/21/17
to django-...@googlegroups.com
#27868: makemessages creates files in '__pycache__' directory by default
-------------------------------------+-------------------------------------
Reporter: MikiSoft | Owner: nobody
Type: Bug | Status: new
Component: Core | Version: 1.10
(Management commands) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
When I run said command without `--locale` parameter, like this:
`manage.py makemessages`
Then it proceeds to create .PO files in each of the folders in my locale
path (which I specified in `settings.py` of course), but it doesn't skip
`__pycache__` - it creates files there, too, but it shouldn't do that.

--
Ticket URL: <https://code.djangoproject.com/ticket/27868>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 22, 2017, 3:44:30 AM2/22/17
to django-...@googlegroups.com
#27868: makemessages creates files in '__pycache__' directory by default
-------------------------------------+-------------------------------------
Reporter: MikiSoft | Owner: nobody
Type: Bug | Status: new
Component: Core (Management | Version: 1.10
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz):

Do you have Python code inside your locale paths?

--
Ticket URL: <https://code.djangoproject.com/ticket/27868#comment:1>

Django

unread,
Feb 22, 2017, 4:44:39 AM2/22/17
to django-...@googlegroups.com
#27868: makemessages creates files in '__pycache__' directory by default
-------------------------------------+-------------------------------------
Reporter: MikiSoft | Owner: nobody
Type: Bug | Status: new
Component: Core (Management | Version: 1.10
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by MikiSoft):

I had them, but in the meantime I moved them to another directory and
removed `__pycache__`.

--
Ticket URL: <https://code.djangoproject.com/ticket/27868#comment:2>

Django

unread,
Feb 22, 2017, 11:56:00 AM2/22/17
to django-...@googlegroups.com
#27868: makemessages creates files in '__pycache__' directory by default
-------------------------------------+-------------------------------------
Reporter: MikiSoft | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* version: 1.10 => master
* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted


Comment:

I guess we should check if dir names look like locale codes.

--
Ticket URL: <https://code.djangoproject.com/ticket/27868#comment:3>

Django

unread,
Feb 22, 2017, 4:01:55 PM2/22/17
to django-...@googlegroups.com
#27868: makemessages creates files in '__pycache__' directory by default
-------------------------------------+-------------------------------------
Reporter: MikiSoft | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/8099 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/27868#comment:4>

Django

unread,
Feb 22, 2017, 4:52:30 PM2/22/17
to django-...@googlegroups.com
#27868: makemessages creates files in '__pycache__' directory by default
-------------------------------------+-------------------------------------
Reporter: MikiSoft | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/27868#comment:5>

Django

unread,
Feb 23, 2017, 3:36:37 AM2/23/17
to django-...@googlegroups.com
#27868: makemessages creates files in '__pycache__' directory by default
-------------------------------------+-------------------------------------
Reporter: MikiSoft | Owner: nobody
Type: | Status: closed

Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"30c984b3f9f7f0249e4a900f6cce5c732c47cf83" 30c984b]:
{{{
#!CommitTicketReference repository=""
revision="30c984b3f9f7f0249e4a900f6cce5c732c47cf83"
Fixed #27868 -- Filtered locale path subdirectories

Thanks Tim Graham for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27868#comment:6>

Reply all
Reply to author
Forward
0 new messages