[Django] #32499: simplify_regex only removes some metacharacters from regex patterns

4 views
Skip to first unread message

Django

unread,
Mar 3, 2021, 12:08:41 AM3/3/21
to django-...@googlegroups.com
#32499: simplify_regex only removes some metacharacters from regex patterns
-------------------------------------+-------------------------------------
Reporter: Rohith P | Owner: Rohith P R
R |
Type: | Status: assigned
Cleanup/optimization |
Component: | Version: 3.1
contrib.admindocs |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
|| Input Pattern || Expected Output || Actual Output ||
|| {{{r'^\b(?P<slug>\w+)\B'}}} || /<slug> || /\b<slug>\B
|| r'\Ab/\Z' || /b/ || /\Ab/\Z

--
Ticket URL: <https://code.djangoproject.com/ticket/32499>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 3, 2021, 2:06:55 AM3/3/21
to django-...@googlegroups.com
#32499: simplify_regex only removes some metacharacters from regex patterns
-------------------------------------+-------------------------------------
Reporter: Rohith P R | Owner: Rohith P
Type: | R
Cleanup/optimization | Status: assigned
Component: contrib.admindocs | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Nick Pope):

* version: 3.1 => master
* stage: Unreviewed => Accepted


Comment:

[https://github.com/django/django/pull/14070 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/32499#comment:1>

Django

unread,
Mar 4, 2021, 7:20:11 AM3/4/21
to django-...@googlegroups.com
#32499: simplify_regex only removes some metacharacters from regex patterns
-------------------------------------+-------------------------------------
Reporter: Rohith P R | Owner: Rohith P
Type: | R
Cleanup/optimization | Status: assigned
Component: contrib.admindocs | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/32499#comment:2>

Django

unread,
Mar 9, 2021, 11:18:52 AM3/9/21
to django-...@googlegroups.com
#32499: simplify_regex only removes some metacharacters from regex patterns
-------------------------------------+-------------------------------------
Reporter: Rohith P R | Owner: Rohith P
Type: | R
Cleanup/optimization | Status: assigned
Component: contrib.admindocs | Version: dev

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Rohith P R):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/32499#comment:3>

Django

unread,
Mar 10, 2021, 2:38:19 AM3/10/21
to django-...@googlegroups.com
#32499: simplify_regex only removes some metacharacters from regex patterns
-------------------------------------+-------------------------------------
Reporter: Rohith P R | Owner: Rohith P
Type: | R
Cleanup/optimization | Status: assigned
Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/32499#comment:4>

Django

unread,
May 12, 2021, 6:09:31 AM5/12/21
to django-...@googlegroups.com
#32499: simplify_regex only removes some metacharacters from regex patterns
-------------------------------------+-------------------------------------
Reporter: Rohith P R | Owner: Nick Pope
Type: | Status: assigned
Cleanup/optimization |

Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Nick Pope):

* owner: Rohith P R => Nick Pope


* needs_better_patch: 1 => 0


Comment:

New [https://github.com/django/django/pull/14385 PR].

--
Ticket URL: <https://code.djangoproject.com/ticket/32499#comment:5>

Django

unread,
Jul 7, 2021, 3:01:13 AM7/7/21
to django-...@googlegroups.com
#32499: simplify_regex only removes some metacharacters from regex patterns
-------------------------------------+-------------------------------------
Reporter: Rohith P R | Owner: Nick Pope
Type: | Status: assigned
Cleanup/optimization |

Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/32499#comment:6>

Django

unread,
Jul 7, 2021, 7:23:44 PM7/7/21
to django-...@googlegroups.com
#32499: simplify_regex only removes some metacharacters from regex patterns
-------------------------------------+-------------------------------------
Reporter: Rohith P R | Owner: Nick Pope
Type: | Status: assigned
Cleanup/optimization |

Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Nick Pope):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/32499#comment:7>

Django

unread,
Sep 22, 2021, 6:03:04 AM9/22/21
to django-...@googlegroups.com
#32499: simplify_regex only removes some metacharacters from regex patterns
-------------------------------------+-------------------------------------
Reporter: Rohith P R | Owner: Nick Pope
Type: | Status: assigned
Cleanup/optimization |

Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/32499#comment:8>

Django

unread,
Sep 22, 2021, 7:10:33 AM9/22/21
to django-...@googlegroups.com
#32499: simplify_regex only removes some metacharacters from regex patterns
-------------------------------------+-------------------------------------
Reporter: Rohith P R | Owner: Nick Pope
Type: | Status: assigned
Cleanup/optimization |

Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"85540da9303287cc13fdce95971a23c9799226f3" 85540da9]:
{{{
#!CommitTicketReference repository=""
revision="85540da9303287cc13fdce95971a23c9799226f3"
Refs #32499 -- Fixed escaped metacharacters in simplify_regex().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32499#comment:11>

Django

unread,
Sep 22, 2021, 7:10:33 AM9/22/21
to django-...@googlegroups.com
#32499: simplify_regex only removes some metacharacters from regex patterns
-------------------------------------+-------------------------------------
Reporter: Rohith P R | Owner: Nick Pope
Type: | Status: closed

Cleanup/optimization |
Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"448d974d9646b96806ef07a9ceeceb96e4bac645" 448d974]:
{{{
#!CommitTicketReference repository=""
revision="448d974d9646b96806ef07a9ceeceb96e4bac645"
Fixed #32499 -- Escaped additional metacharacters in simplify_regex().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32499#comment:12>

Django

unread,
Sep 22, 2021, 7:10:33 AM9/22/21
to django-...@googlegroups.com
#32499: simplify_regex only removes some metacharacters from regex patterns
-------------------------------------+-------------------------------------
Reporter: Rohith P R | Owner: Nick Pope
Type: | Status: assigned
Cleanup/optimization |

Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"27189af8cf2760e6aaf10ca1aa77994985212f4d" 27189af]:
{{{
#!CommitTicketReference repository=""
revision="27189af8cf2760e6aaf10ca1aa77994985212f4d"
Refs #32499 -- Added metacharacters helper for simplify_regex().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32499#comment:9>

Django

unread,
Sep 22, 2021, 7:10:33 AM9/22/21
to django-...@googlegroups.com
#32499: simplify_regex only removes some metacharacters from regex patterns
-------------------------------------+-------------------------------------
Reporter: Rohith P R | Owner: Nick Pope
Type: | Status: assigned
Cleanup/optimization |

Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"9f7809ece37cc8b5f3239908fbdcebe32606ce2d" 9f7809ec]:
{{{
#!CommitTicketReference repository=""
revision="9f7809ece37cc8b5f3239908fbdcebe32606ce2d"
Refs #32499 -- Added more tests for simplify_regex().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32499#comment:10>

Reply all
Reply to author
Forward
0 new messages