Re: [Django] #32065: Documentation for settings.CSRF_COOKIE_DOMAIN confusing
Django
-------------------------------------+-------------------------------------
Reporter: Anthony | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: 3.1
Severity: Normal | Resolution:
Keywords: cookie, domain, | Triage Stage:
csrf | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Anthony):
* cc: Anthony (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/32065#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
| Gibson
Type: Bug | Status: closed
Component: Documentation | Version: 3.1
Severity: Normal | Resolution: fixed
Keywords: cookie, domain, | Triage Stage: Ready for
csrf | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"3d4ffd1ff0eb9343ee41de77caf6ae427b6e873c" 3d4ffd1f]:
{{{
#!CommitTicketReference repository=""
revision="3d4ffd1ff0eb9343ee41de77caf6ae427b6e873c"
Fixed #32065 -- Restored leading dot to CSRF_COOKIE_DOMAIN examples.
Partially reverts afd375fc343baa46e61036087bc43b3d096bb0ca.
Thanks to Tim Graham for review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32065#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Anthony | Owner: Carlton
| Gibson
Type: Bug | Status: closed
Component: Documentation | Version: 3.1
Severity: Normal | Resolution: fixed
Keywords: cookie, domain, | Triage Stage: Ready for
csrf | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"2e7ba6057cfc82a15a22b6021cd60cf307152e2d" 2e7ba605]:
{{{
#!CommitTicketReference repository=""
revision="2e7ba6057cfc82a15a22b6021cd60cf307152e2d"
Refs #28741 -- Doc'd SESSION_COOKIE_DOMAIN requirement with
CSRF_USE_SESSIONS.
Similar considerations as refs #32065, again adding some nuance to
afd375fc343baa46e61036087bc43b3d096bb0ca.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32065#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Anthony | Owner: Carlton
| Gibson
Type: Bug | Status: closed
Component: Documentation | Version: 3.1
Severity: Normal | Resolution: fixed
Keywords: cookie, domain, | Triage Stage: Ready for
csrf | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"f4db2d16ec42922078ff1951cd696c9b49e1e2f6" f4db2d1]:
{{{
#!CommitTicketReference repository=""
revision="f4db2d16ec42922078ff1951cd696c9b49e1e2f6"
[3.1.x] Refs #28741 -- Doc'd SESSION_COOKIE_DOMAIN requirement with
CSRF_USE_SESSIONS.
Similar considerations as refs #32065, again adding some nuance to
afd375fc343baa46e61036087bc43b3d096bb0ca.
Backport of 2e7ba6057cfc82a15a22b6021cd60cf307152e2d from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32065#comment:7>