[Django] #17209: Dogfood class-based views in contrib.auth

Django

unread,

Nov 12, 2011, 4:26:52 AM11/12/11

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: SVN
Component: contrib.auth | Keywords: class-based views admin
Severity: Normal | auth
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Right now, the views provided by contrib.auth are not very extensible,
since they are still functional. It would be great to add class-based
versions which could eventually replace the functional versions. This is
related to #17208; when this change is made, the admin login view should
be tweaked to extend the new view.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Nov 17, 2011, 5:13:37 PM11/17/11

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: SVN

* needs_better_patch: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 0
* needs_docs: => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:1>

Django

unread,

Dec 11, 2011, 8:07:29 PM12/11/11

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: SVN

Changes (by dstufft):

* cc: dstufft (added)

Comment:

I'm taking a crack at this. I've started working on it in my branch on
github: https://github.com/dstufft/django/tree/feature/contrib-auth-cbv

So far i've gotten the LoginView switched to a CBV with a shim to
translate login -> LoginView and switching the auth specific kwarg names
to match the more generic kwarg names in FormView.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:2>

Django

unread,

Mar 27, 2012, 10:26:09 AM3/27/12

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: SVN

Changes (by seldon):

* cc: seldon (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:3>

Django

unread,

May 2, 2012, 1:00:20 AM5/2/12

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new
Cleanup/optimization | Version: master

Changes (by andrews):

* owner: nobody => andrews
* cc: andrewsmedina@… (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:4>

Django

unread,

May 4, 2012, 1:12:45 PM5/4/12

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Changes (by bmispelon):

* cc: bmispelon (added)

Comment:

I've made some pogress on this: https://gist.github.com/1851113

It still needs tests and documentation but I'm hoping to work on it during
the sprints at djangocon europe next month.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:5>

Django

unread,

May 4, 2012, 1:32:17 PM5/4/12

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Comment (by andrews):

bmispelon I can help you with that. You could add me to your fork on
github?

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:6>

Django

unread,

May 5, 2012, 2:49:37 AM5/5/12

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Comment (by bmispelon):

Replying to [comment:6 andrews]:

> bmispelon I can help you with that. You could add me to your fork on
github?

I made a proper fork of django's new github repo:
https://github.com/bmispelon/django and committed my changes.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:7>

Django

unread,

Jun 7, 2012, 1:07:53 PM6/7/12

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Comment (by bmispelon):

After two minor modifications, I've got all the tests passing on my fork.

There are still a few things I'd like to improve, mostly around the
redirection logic in LoginView and LogoutView (it's still messy).

I've had a hard time wrapping my head around the flow of the function-
based logout view. I'd appreciate it if someone could make sure I did
actually replicate it.

I also have a few questions:

* LogoutView: For now, it inherits from TemplateView. Does it make more
sense to inherit from RedirectView (RedirectView has the nice advantage of
dispatching POST, OPTIONS, DELETE, and PUT to GET)? Or maybe simply View?

* PasswordResetConfirmView: as mentionned in the comment on the code,
there is a potential backwards-compatibility issue. It should not be too
hard to correct it but is it really a problem?

* Backwards-compatible stubs: the approach I took to ensure backwards-
compatibility was to create function based wrappers around the class-based
views. Is this a good approach?

* How do I approach writing tests for these new class-based views? I'm
having a hard time determining what should be tested and how.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:8>

Django

unread,

Jun 9, 2012, 4:10:22 AM6/9/12

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Comment (by bmispelon):

I've made some more improvements and reached a point where I'm pretty
satisfied with the code.

I'm going to attempt writing some documentation now, using the work done
by pydanny in the pull request #144 (it hasn't been accepted yet as I'm
writing this).

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:9>

Django

unread,

Jun 22, 2012, 2:45:27 PM6/22/12

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Comment (by anonymous):

Also check out #16197 which has been closed as a duplicate of this ticket.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:10>

Django

unread,

Jul 23, 2012, 9:43:50 AM7/23/12

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Changes (by vzima):

* cc: vlastimil.zima@… (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:11>

Django

unread,

Aug 18, 2012, 2:07:41 PM8/18/12

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Cleanup/optimization | Version: master
Component: contrib.auth | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: class-based views | Needs documentation: 0

admin auth | Patch needs improvement: 1

Has patch: 0 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Changes (by mjtamlyn):

* cc: marc.tamlyn@… (added)
* needs_better_patch: 0 => 1

Comment:

I've tried bringing the patch up to the current master. Most of the tests
pass and it seems to be ok, but there's something weird going on with the
way that the wrapper shim works.

On discussion with andrewgodwin we've come up with the following changes:

1) Remove the wrapper shim, and convert all of the keyword arguments to
kwargs. We can handle `extra_context` by updating the context on the
`TemplateResponse` object returned from the CBV.

2) Tests: the new tests should be entirely equivalent to the old tests,
but also separate. So a new set of urls linked to the cbv views, and
retest all the expected behaviour. We should then be able to deprecate
things easily when the time comes.

3) !Docs/Release notes. The functional views documentation can be removed,
and we can convert each part of the docs to now document the new, class
based version.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:12>

Django

unread,

Aug 20, 2012, 8:16:24 AM8/20/12

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Comment (by mjtamlyn):

Ok, I've got all of the tests working again and updated the wrapping of
the new views with the old ones.

The code is visible here: https://github.com/mjtamlyn/django/compare/auth-
cbv

The last thing to add to the list above is integrating these changes with
the rest of django. The auth views are used by the admin, flatpages and
other parts of auth and these should be updated to use the new cbv
approach.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:13>

Django

unread,

Nov 7, 2012, 12:20:03 PM11/7/12

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Comment (by ptone):

an interesting related bit to note here - is making the password reset
process more flexible for custom users via CBV views:

http://pypi.python.org/pypi/django-password-reset

via

https://groups.google.com/forum/?fromgroups=#!topic/django-
developers/NNnDVzoNQbU

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:14>

Django

unread,

Nov 25, 2012, 12:11:13 PM11/25/12

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Comment (by bmispelon):

I just pulled master back into my branch:
https://github.com/bmispelon/django/compare/auth-cbv

I thought the new swappable user model would break a lot of things but it
turned out much easier than expected.

I've been looking into moving `contrib.admin` to use the new CBV but what
I have so far is pretty ugly because the admin uses a lot of the old
`extra_context` parameter, which requires CBV to create a
`get_context_data` method.

As for flatpages, it only uses `redirect_to_login` which we didn't touch.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:15>

Django

unread,

Apr 10, 2013, 4:21:18 AM4/10/13

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Comment (by claudep):

It looks nice. It would be nice to rebase/merge the commits, write some
documentation and generate a pull request so we can comment on it.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:16>

Django

unread,

Jun 4, 2013, 2:12:32 AM6/4/13

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Comment (by rockymeza):

I opened a pull request for this ticket
https://github.com/django/django/pull/1239

This pull request is different from
https://github.com/bmispelon/django/compare/auth-cbv in a couple ways:

1. There is no wrapper shim. The views extract the old parameters from
kwargs. This has the benefit of subclasses still supporting the old view
invocation.
2. It uses the DecoratorMixin pattern described in
https://groups.google.com/d/msg/django-
developers/jrfbenCJYYU/6aiH2sebnlAJ. This is controversial, yes, but it
does mean a subclass will never lose its decorators should someone
override dispatch.
3. It is rebased on master.

I was going to write some documentation for the class-based views, but I
was wondering if we should maintain (and keep documented) the function
view kwarg parameters or if they should be truly deprecated. All access
to those function view kwarg parameters is regulated through one piece of
code, so it would be possible to deprecate them easily. I'm in favor of
deprecating the function view kwargs, 1) because they are terribly
inconsistent (`post_reset_redirect` vs. `post_change_redirect`) and 2) to
embrace the established class-based views APIs.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:17>

Django

unread,

Jun 4, 2013, 3:36:23 AM6/4/13

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Comment (by mjtamlyn):

I'm not particularly fond of the approach you've taken here. I think we
should not be trying to support some of the more obscure customisation
points which existed historically. I agreed with some of the other core
devs that the best way to proceed is to leave the old code as is, but with
deprecation warnings, and create new views which are well designed to the
new way of doing things, and provide a more consistent feeling API to the
main GCBVs.

Other points:
If we're going to include the `DecoratorMixin`then we should include it in
a more logical place in the code base
Patch is completely missing tests - the tests for auth views are not
complete as it is, so they need expanding to cover all the branches as
well. Also they need to check all the deprecated views still work.
There are lots of minor style points - for example the use of
`resolve_url` rather than `reverse`

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:18>

Django

unread,

Jun 4, 2013, 4:44:36 AM6/4/13

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Comment (by bmispelon):

Hi,

I worked with Marc on this issue during the sprints at Djangocon Europe
last month (and last year too).
Admitedly, I haven't made much progress on this since, but I haven't given
up and I still work on it from time to time.

As it's often the case, writing the code is the easier part. I think the
code we have is pretty good now and I don't see much advantage in tweaking
it further (except maybe the idea of using the `DecoratorMixin`, see
later).

As Marc mentionned, we've more or less settled on the idea of creating
plain CBV, without any backwards-compatibility layer.
We would then keep the old function-based views around, with a deprecation
warning as per the deprecation policy.
This allows us to start on a relative clean slate and get rid of the cruft
that's been added over the years.

With the code settled, what's preventing this ticket from moving further
has more to do with things like tests, documentation, and other parts of
django that need to be cleaned up.

For example, there are a few places in django that assume the presence of
function-based views inside `contrib/auth/views.py` so those need to be
fixed (I'm currently working on this).
There's also the issue of the admin which makes heavy use of the auth
views and their configuration options. In particular, it uses
`extra_context` which doesn't map well to class-based views.

One thing to note is that with this rewrite, `django.contrib.auth` would
become the first app in django that ships with non-generic class-based
views.
This means that we need to come up with a way of both documenting and
testing these views.
This is not completely straighforward, especially considering that
whatever we come up with would probably be regarded as some sort of canon
on how to test/document non-generic class-based views.

Personally, I'd rather take some more time and do this properly (clean up
the code, tests and doc) rather than cut corners and ship something still
half-broken with backwards-compatibility cruft.

Finally, regarding the `DecoratorMixin`:
I like the idea but I wonder if shouldn't be in a separate ticket.
I think the feature makes sense on its own and with the more litmited
scope that it has,
it would stand a better chance of getting commited separately.

Thanks.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:19>

Django

unread,

Jun 4, 2013, 4:33:20 PM6/4/13

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Comment (by bmispelon):

I just pushed all the things I had left from the sprints onto
https://github.com/bmispelon/django/compare/master...auth-cbv (I also
merged the latest changes from master).

Here's what needs to be done next:
* Move all the `contrib.auth.test_views` to a new `test_legacy_views`
file.
* Come up with a way of testing the class-based views (2 things need to be
tested separately: the fact that the view itself works as intended, and
its extension points).
* Document the new class-based views.
* Fix `contrib.admin`'s usage of the auth views. As I mentionned before,
the usage of the old `extra_context` parameter is what's causing problems
here.

Out of these 4 points, only the first one is fairly easy (it's just some
heavy copy/pasting and moving files around). The other 3 will be more
tricky and I worry that the fixing of `contrib.admin` might unveil some
more complicated issues.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:20>

Django

unread,

Aug 14, 2014, 4:51:02 AM8/14/14

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Comment (by japrogramer):

(above) just attached a file with my improvements on the auth views, they
are now CBV and have function gateways to maintain backwards compatability
but users can easily import the CBV and override functions to extend or
modify functionality :D

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:21>

Django

unread,

Aug 14, 2014, 11:05:37 AM8/14/14

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Has patch: 1 | UI/UX: 0
Needs tests: 1 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by japrogramer):

* has_patch: 0 => 1
* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:22>

Django

unread,

Aug 14, 2014, 11:11:52 AM8/14/14

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new

Needs tests: 0 |

Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by japrogramer):

* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:23>

Django

unread,

Mar 11, 2015, 2:16:54 AM3/11/15

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: andrews
Type: | Status: new
Cleanup/optimization |

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by auvipy):

hi willing to work on this related tickets for gsoc this year. willing to
assigning myself for now. will be analyzing the related tickets for a good
proposal. looking forward to you guys kind suggestions :)

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:24>

Django

unread,

Mar 11, 2015, 3:58:19 AM3/11/15

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: melinath | Owner: auvipy
Type: | Status: assigned

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by auvipy):

* owner: andrews => auvipy
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:25>

Django

unread,

May 4, 2015, 12:49:16 AM5/4/15

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: auvipy
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: class-based views | Triage Stage: Accepted
admin auth |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by auvipy):

starting work on this. mainly cleanly implement the patch of japrogramer.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:26>

Django

unread,

Sep 30, 2015, 7:12:32 PM9/30/15

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: auvipy
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: class-based views | Triage Stage: Accepted
admin auth |

Has patch: 1 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by auvipy):

* needs_docs: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:27>

Django

unread,

Oct 11, 2015, 1:26:08 PM10/11/15

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: auvipy
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: class-based views | Triage Stage: Accepted
admin auth |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by auvipy):

Targeting this for 1.10

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:28>

Django

unread,

Apr 20, 2016, 4:15:40 AM4/20/16

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: auvipy
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: class-based views | Triage Stage: Accepted
admin auth |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by claudep):

auvipy, still working on this?

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:29>

Django

unread,

Apr 20, 2016, 10:05:43 AM4/20/16

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: auvipy
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: class-based views | Triage Stage: Accepted
admin auth |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by auvipy):

Replying to [comment:29 claudep]:

> auvipy, still working on this?

If you are willing to take it over for your personal sprint then OK but
if not then I would be happy to start work on it. been busy with other
projects.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:30>

Django

unread,

Apr 20, 2016, 1:35:24 PM4/20/16

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: auvipy
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: class-based views | Triage Stage: Accepted
admin auth |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by claudep):

If you think you'll be able to work on it before the feature freeze (Mai
16th), then fine. If not, then simply deassign yourself.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:31>

Django

unread,

May 15, 2016, 4:06:49 PM5/15/16

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: auvipy
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: class-based views | Triage Stage: Accepted
admin auth |

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by claudep):

* needs_better_patch: 1 => 0
* needs_docs: 1 => 0

Comment:

I added a patch for only login and logout in
[https://github.com/django/django/pull/6607 this PR]. We might consider
doing the password reset views later.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:32>

Django

unread,

Jun 2, 2016, 8:50:14 PM6/2/16

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by phildini):

* needs_better_patch: 0 => 1

Comment:

I think the code looks good, and includes appropriate test changes.
However, the patch needs to be rebased, and the references to 1.10 should
be set to the next version.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:33>

Django

unread,

Jun 9, 2016, 5:24:19 AM6/9/16

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by claudep):

* needs_better_patch: 1 => 0

Comment:

Patch rebased.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:34>

Django

unread,

Jun 10, 2016, 2:33:04 PM6/10/16

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: auvipy
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:

Keywords: class-based views | Triage Stage: Ready for
admin auth | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by phildini):

* stage: Accepted => Ready for checkin

Comment:

I think the code looks good, tests pass, and there is updated
documentation. Marking "Ready For Checkin", happy to be corrected.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:35>

Django

unread,

Jun 10, 2016, 3:23:46 PM6/10/16

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: auvipy
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:

Keywords: class-based views | Triage Stage: Accepted
admin auth |

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by timgraham):

* stage: Ready for checkin => Accepted

Comment:

I see a few things for improvement. Will review it soon.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:36>

Django

unread,

Jun 22, 2016, 2:04:21 PM6/22/16

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner:

Type: | Status: new

Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:

Keywords: class-based views | Triage Stage: Ready for
admin auth | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* owner: auvipy =>
* status: assigned => new

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:37>

Django

unread,

Jun 24, 2016, 4:46:09 AM6/24/16

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner:
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: class-based views | Triage Stage: Ready for
admin auth | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"78963495d0caadb77eb97ccf319ef0ba3b204fb5" 7896349]:
{{{
#!CommitTicketReference repository=""
revision="78963495d0caadb77eb97ccf319ef0ba3b204fb5"
Refs #17209 -- Added LoginView and LogoutView class-based views

Thanks Tim Graham for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:38>

Django

unread,

Jun 24, 2016, 4:48:23 AM6/24/16

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner:
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:

Keywords: class-based views | Triage Stage: Accepted
admin auth |

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by claudep):

* has_patch: 1 => 0

* stage: Ready for checkin => Accepted

Comment:

Now to the password change/reset views...

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:39>

Django

unread,

Jun 30, 2016, 9:34:16 AM6/30/16

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner:
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: class-based views | Triage Stage: Accepted
admin auth |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by claudep):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/6854 PR] for the password-related
views.

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:40>

Django

unread,

Jul 8, 2016, 11:09:06 AM7/8/16

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner:
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:

Keywords: class-based views | Triage Stage: Ready for
admin auth | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by timgraham):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:41>

Django

unread,

Jul 16, 2016, 5:07:18 AM7/16/16

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Changes (by Claude Paroz <claude@…>):

* owner: => Claude Paroz <claude@…>
* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"255fb992845e987ef36e3d721a77747a0b2df620" 255fb992]:
{{{
#!CommitTicketReference repository=""
revision="255fb992845e987ef36e3d721a77747a0b2df620"
Fixed #17209 -- Added password reset/change class-based views

Thanks Tim Graham for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:42>

Django

unread,

Nov 21, 2016, 2:07:55 PM11/21/16

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: Claude
Type: | Paroz <claude@…>
Cleanup/optimization | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: class-based views | Triage Stage: Ready for
admin auth | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"51eaff6d359065cbf790a649ca2061581af23711" 51eaff6d]:
{{{
#!CommitTicketReference repository=""
revision="51eaff6d359065cbf790a649ca2061581af23711"
Refs #17209 -- Fixed token verification for PasswordResetConfirmView POST
requests.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:43>

Django

unread,

Feb 14, 2017, 6:36:52 PM2/14/17

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------

Reporter: Stephen Burrows | Owner: Claude

Comment (by Markus Holtermann <info@…>):

In [changeset:"b9b35f9efabc19f6c58f2d5962a9e6d8dc53a786" b9b35f9e]:
{{{
#!CommitTicketReference repository=""
revision="b9b35f9efabc19f6c58f2d5962a9e6d8dc53a786"
Fixed #27840 -- Fixed KeyError in PasswordResetConfirmView.form_valid().

When a user is already logged in when submitting the password and
password confirmation to reset a password, a KeyError occurred while
removing the reset session token from the session.

Refs #17209

Thanks Quentin Marlats for the report and Florian Apolloner and Tim
Graham for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:44>

Django

unread,

Feb 14, 2017, 6:40:01 PM2/14/17

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: Stephen Burrows | Owner: Claude
Type: | Paroz <claude@…>
Cleanup/optimization | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: class-based views | Triage Stage: Ready for
admin auth | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Markus Holtermann <info@…>):

In [changeset:"f5ff5be2c11613e611f53ba4d6b194675811cbad" f5ff5be2]:
{{{
#!CommitTicketReference repository=""
revision="f5ff5be2c11613e611f53ba4d6b194675811cbad"
[1.11.x] Fixed #27840 -- Fixed KeyError in
PasswordResetConfirmView.form_valid().

When a user is already logged in when submitting the password and
password confirmation to reset a password, a KeyError occurred while
removing the reset session token from the session.

Refs #17209

Thanks Quentin Marlats for the report and Florian Apolloner and Tim
Graham for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:45>

Django

unread,

Sep 22, 2017, 1:39:49 PM9/22/17

to django-...@googlegroups.com

#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: Stephen Burrows | Owner: Claude
Type: | Paroz <claude@…>
Cleanup/optimization | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: class-based views | Triage Stage: Ready for
admin auth | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"4f313e284e03a675da5fb1d25122ac9b04af5950" 4f313e2]:
{{{
#!CommitTicketReference repository=""
revision="4f313e284e03a675da5fb1d25122ac9b04af5950"
Refs #17209 -- Removed login/logout and password reset/change function-
based views.