[Django] #26119: Catch ValueError while parsing urls in URLValidator
Django
-------------------------------+--------------------
Reporter: EnTeQuAk | Owner: nobody
Type: Uncategorized | Status: new
Component: Forms | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
Django uses `urllib.urlsplit` to parse an URL but in certain cases this is
failing on URLs the regular expressions in `URLValidator` deem valid.
This appears to be a problem in 1.6+
--
Ticket URL: <https://code.djangoproject.com/ticket/26119>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: EnTeQuAk | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by EnTeQuAk):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
* has_patch: 0 => 1
* type: Uncategorized => Bug
Old description:
> Django uses `urllib.urlsplit` to parse an URL but in certain cases this
> is failing on URLs the regular expressions in `URLValidator` deem valid.
>
> This appears to be a problem in 1.6+
New description:
Django uses `urllib.urlsplit` to parse an URL but in certain cases this is
failing on URLs the regular expressions in `URLValidator` deem valid.
This appears to be a problem in 1.6+
Pull Request: https://github.com/django/django/pull/6010
--
--
Ticket URL: <https://code.djangoproject.com/ticket/26119#comment:1>
Django
Reporter: EnTeQuAk | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Description changed by EnTeQuAk:
Old description:
> Django uses `urllib.urlsplit` to parse an URL but in certain cases this
> is failing on URLs the regular expressions in `URLValidator` deem valid.
>
> This appears to be a problem in 1.6+
>
> Pull Request: https://github.com/django/django/pull/6010
New description:
Django uses `urllib.urlsplit` to parse an URL but in certain cases this is
failing on URLs the regular expressions in `URLValidator` deems valid.
This appears to be a problem in 1.6+
Pull Request: https://github.com/django/django/pull/6010
--
--
Ticket URL: <https://code.djangoproject.com/ticket/26119#comment:2>
Django
Reporter: EnTeQuAk | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Description changed by EnTeQuAk:
Old description:
> Django uses `urllib.urlsplit` to parse an URL but in certain cases this
> is failing on URLs the regular expressions in `URLValidator` deems valid.
>
> This appears to be a problem in 1.6+
>
> Pull Request: https://github.com/django/django/pull/6010
New description:
Django uses `urllib.urlsplit` to parse an URL but in certain cases this is
failing on URLs the regular expressions in `URLValidator` deems valid.
This appears to be a problem at least in 1.6+, probably since the
`URLValidator` exists.
Pull Request: https://github.com/django/django/pull/6010
--
--
Ticket URL: <https://code.djangoproject.com/ticket/26119#comment:3>
Django
Reporter: EnTeQuAk | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by MarkusH):
* version: 1.9 => master
* stage: Unreviewed => Accepted
Comment:
Can confirm on 1.8 upwards.
--
Ticket URL: <https://code.djangoproject.com/ticket/26119#comment:4>
Django
Reporter: EnTeQuAk | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
Comment:
As noted on the pull request, looks like a few test cases are missing.
--
Ticket URL: <https://code.djangoproject.com/ticket/26119#comment:5>
Django
Reporter: EnTeQuAk | Owner: nobody
Type: Bug | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by timgraham):
* component: Forms => Core (Other)
--
Ticket URL: <https://code.djangoproject.com/ticket/26119#comment:6>
Django
Reporter: EnTeQuAk | Owner: nobody
Type: Bug | Status: closed
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"a9e188ccd6315d278795355a53bce6c1a63f5a50" a9e188c]:
{{{
#!CommitTicketReference repository=""
revision="a9e188ccd6315d278795355a53bce6c1a63f5a50"
Fixed #26119 -- Fixed URLValidator crash on URLs with brackets.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26119#comment:7>
Django
Reporter: EnTeQuAk | Owner: nobody
Type: Bug | Status: closed
Component: Core (Other) | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by Tim Graham <timograham@…>):
In [changeset:"712838a53d03fd6644da8bce4c3a7b2e19f56df2" 712838a]:
{{{
#!CommitTicketReference repository=""
revision="712838a53d03fd6644da8bce4c3a7b2e19f56df2"
[1.10.x] Fixed #26119 -- Fixed URLValidator crash on URLs with brackets.
Backport of a9e188ccd6315d278795355a53bce6c1a63f5a50 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26119#comment:8>