[Django] #30447: Add is_in_european_union to GeoIP2.city dict

10 views
Skip to first unread message

Django

unread,
May 5, 2019, 9:03:47 PM5/5/19
to django-...@googlegroups.com
#30447: Add is_in_european_union to GeoIP2.city dict
---------------------------------------+------------------------
Reporter: c23gooey | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: 2.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------+------------------------
Maxmind data supplies european union information as part of both the free
and paid database sets.

This isn't accessible from the GeoIP2 city dict, despite it being
available.

--
Ticket URL: <https://code.djangoproject.com/ticket/30447>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 5, 2019, 9:06:12 PM5/5/19
to django-...@googlegroups.com
#30447: Add is_in_european_union to GeoIP2.city dict
-----------------------------+--------------------------------------

Reporter: c23gooey | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: 2.2
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------+--------------------------------------
Description changed by c23gooey:

Old description:

> Maxmind data supplies european union information as part of both the free
> and paid database sets.
>
> This isn't accessible from the GeoIP2 city dict, despite it being
> available.

New description:

Maxmind data supplies european union information as part of both the free
and paid database sets.

This isn't accessible from the GeoIP2 city dict, despite it being
available.

PR on GitHub = https://github.com/django/django/pull/11327

--

--
Ticket URL: <https://code.djangoproject.com/ticket/30447#comment:1>

Django

unread,
May 6, 2019, 4:54:59 AM5/6/19
to django-...@googlegroups.com
#30447: Add is_in_european_union to GeoIP2.city() dict.
------------------------------+----------------------------------------
Reporter: Chris Adkins | Owner: Chris Adkins
Type: New feature | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+----------------------------------------
Changes (by felixxm):

* status: new => assigned
* version: 2.2 => master
* owner: nobody => Chris Adkins
* has_patch: 0 => 1
* stage: Unreviewed => Accepted


Old description:

> Maxmind data supplies european union information as part of both the free
> and paid database sets.
>
> This isn't accessible from the GeoIP2 city dict, despite it being
> available.
>

New description:

Maxmind data supplies european union information as part of both the free
and paid database sets.

This isn't accessible from the GeoIP2 city dict, despite it being
available.

PR on GitHub = https://github.com/django/django/pull/11327

--

Comment:

[https://github.com/django/django/pull/11327 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/30447#comment:2>

Django

unread,
May 6, 2019, 1:35:47 PM5/6/19
to django-...@googlegroups.com
#30447: Add is_in_european_union to GeoIP2.city() dict.
------------------------------+----------------------------------------
Reporter: Chris Adkins | Owner: Chris Adkins
Type: New feature | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+----------------------------------------
Changes (by Claude Paroz):

* needs_docs: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/30447#comment:3>

Django

unread,
May 6, 2019, 11:53:24 PM5/6/19
to django-...@googlegroups.com
#30447: Add is_in_european_union to GeoIP2.city() dict.
------------------------------+----------------------------------------
Reporter: Chris Adkins | Owner: Chris Adkins
Type: New feature | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+----------------------------------------

Comment (by Chris Adkins):

have added is_in_european_union to the example in the docs,
not sure what else is needed here?

--
Ticket URL: <https://code.djangoproject.com/ticket/30447#comment:4>

Django

unread,
May 6, 2019, 11:54:10 PM5/6/19
to django-...@googlegroups.com
#30447: Add is_in_european_union to GeoIP2.city() dict.
------------------------------+----------------------------------------
Reporter: Chris Adkins | Owner: Chris Adkins
Type: New feature | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+----------------------------------------
Changes (by Chris Adkins):

* needs_docs: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/30447#comment:5>

Django

unread,
May 7, 2019, 7:32:20 AM5/7/19
to django-...@googlegroups.com
#30447: Add is_in_european_union to GeoIP2.city() dict.
------------------------------+----------------------------------------
Reporter: Chris Adkins | Owner: Chris Adkins
Type: New feature | Status: closed
Component: GIS | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+----------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"705ef6cfebe000df1971e25ee269c2e26bac18f4" 705ef6cf]:
{{{
#!CommitTicketReference repository=""
revision="705ef6cfebe000df1971e25ee269c2e26bac18f4"
Fixed #30447 -- Added 'is_in_european_union' in GeoIP2.city() dict.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30447#comment:6>

Reply all
Reply to author
Forward
0 new messages