[Django] #29353: Static files path cannot be the same as directory name?
Django
-------------------------------------+-------------------------------------
Reporter: koxu1996 | Owner: nobody
Type: Bug | Status: new
Component: | Version: 2.0
Uncategorized | Keywords: static-files
Severity: Normal | testing server
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
I created ''functional_tests'' directory with empty ''__init__.py'' and
''test_all.py'' containing following code:
{{{
from django.test import LiveServerTestCase
from selenium import webdriver
class DemoTest(LiveServerTestCase):
def test_can_get_empty_list_of_server_seeds(self):
self.browser = webdriver.Firefox()
print('Before page open')
self.browser.get(self.live_server_url + '/')
print('After page open')
self.assertEqual(1, 1)
self.browser.quit()
}}}
Running it with 'python manage.py test functional_tests/' result with
success:
{{{
...
Before page open
After page open
.
----------------------------------------------------------------------
Ran 1 test in 7.048s
OK
...
}}}
But if I change LiveServerTestCase to StaticLiveServerTestCase then I am
getting strange error:
{{{
$ python manage.py test functional_tests/
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
Before page open
Traceback (most recent call last):
File "/usr/lib/python3.6/wsgiref/handlers.py", line 137, in run
self.result = application(self.environ, self.start_response)
File "/usr/lib/python3.6/site-
packages/django/contrib/staticfiles/handlers.py", line 67, in __call__
return super().__call__(environ, start_response)
File "/usr/lib/python3.6/site-packages/django/core/handlers/wsgi.py",
line 146, in __call__
response = self.get_response(request)
File "/usr/lib/python3.6/site-
packages/django/contrib/staticfiles/handlers.py", line 62, in get_response
return super().get_response(request)
File "/usr/lib/python3.6/site-packages/django/core/handlers/base.py",
line 81, in get_response
response = self._middleware_chain(request)
TypeError: 'NoneType' object is not callable
Traceback (most recent call last):
File "/usr/lib/python3.6/wsgiref/handlers.py", line 137, in run
self.result = application(self.environ, self.start_response)
File "/usr/lib/python3.6/site-
packages/django/contrib/staticfiles/handlers.py", line 67, in __call__
return super().__call__(environ, start_response)
File "/usr/lib/python3.6/site-packages/django/core/handlers/wsgi.py",
line 146, in __call__
response = self.get_response(request)
File "/usr/lib/python3.6/site-
packages/django/contrib/staticfiles/handlers.py", line 62, in get_response
return super().get_response(request)
File "/usr/lib/python3.6/site-packages/django/core/handlers/base.py",
line 81, in get_response
response = self._middleware_chain(request)
TypeError: 'NoneType' object is not callable
After page open
.
----------------------------------------------------------------------
Ran 1 test in 6.659s
OK
Destroying test database for alias 'default'...
}}}
This is my part of my settings:
{{{
STATIC_URL = '/static/'
STATIC_ROOT = "/var/www/html/casino/static/"
}}}
It seems that url path cannot have the same name, because if I change
STATIC_URL or STATIC_ROOT then everything works fine.
--
Ticket URL: <https://code.djangoproject.com/ticket/29353>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: koxu1996 | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: static-files | Triage Stage:
testing server | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham):
Can you please debug the issue and explain why Django is at fault? Or at
least provide a sample project that reproduces the problem. I can't
reproduce a problem given the information you provided.
--
Ticket URL: <https://code.djangoproject.com/ticket/29353#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: koxu1996 | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: static-files | Triage Stage:
testing server | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* Attachment "issue.tar.gz" added.
Django
-------------------------------------+-------------------------------------
Reporter: koxu1996 | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: static-files | Triage Stage:
testing server | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by koxu1996):
Replying to [comment:1 Tim Graham]:
> Can you please debug the issue and explain why Django is at fault? Or at
least provide a sample project that reproduces the problem. I can't
reproduce a problem given the information you provided.
I added attachment with sample project.
--
Ticket URL: <https://code.djangoproject.com/ticket/29353#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: koxu1996 | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: staticfiles | Triage Stage:
middleware_chain | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* keywords: static-files testing server => staticfiles middleware_chain
* component: Uncategorized => contrib.staticfiles
Old description:
New description:
class DemoTest(LiveServerTestCase):
self.assertEqual(1, 1)
}}}
--
--
Ticket URL: <https://code.djangoproject.com/ticket/29353#comment:3>
Django
Reporter: koxu1996 | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: staticfiles | Triage Stage:
middleware_chain | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by koxu1996):
l probably figured it out: just compare load_middleware() in BaseHandler
and StaticFilesHandler. The former is setting _middleware_chain property,
but second does not do anything:
{{{
class StaticFilesHandler(WSGIHandler):
...
def load_middleware(self):
# Middleware are already loaded for self.application; no need to
reload
# them for self.
pass
}}}
I see two possible solutions:
- set _middleware_chain in StaticFilesHandler.load_middleware()
- check if _middleware_chain is not empty before calling it
--
Ticket URL: <https://code.djangoproject.com/ticket/29353#comment:4>
Django
-------------------------------------+-------------------------------------
| Paroz
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: 2.0
Severity: Normal | Resolution:
middleware_chain |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => Claude Paroz
* status: new => assigned
* stage: Unreviewed => Accepted
Comment:
That's an issue with a 404 response when settings.DEBUG is False, it
shouldn't fallback to `super().get_response(request)` in that case.
--
Ticket URL: <https://code.djangoproject.com/ticket/29353#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: koxu1996 | Owner: Claude
| Paroz
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: 2.0
Severity: Normal | Resolution:
Keywords: staticfiles | Triage Stage: Accepted
middleware_chain |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/9901 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/29353#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: koxu1996 | Owner: Claude
| Paroz
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: 2.0
Severity: Normal | Resolution:
Keywords: staticfiles | Triage Stage: Accepted
middleware_chain |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by koxu1996):
Replying to [comment:6 Claude Paroz]:
> [https://github.com/django/django/pull/9901 PR]
It is working, so I look forward to merge.
BTW do you know why there is 404 error? Should not be ''/static'' served
even though STATICFILES_DIRS is not set and no files are collected?
--
Ticket URL: <https://code.djangoproject.com/ticket/29353#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: koxu1996 | Owner: Claude
| Paroz
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: 2.0
Severity: Normal | Resolution:
middleware_chain | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/29353#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: koxu1996 | Owner: Claude
| Paroz
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: 2.0
Severity: Normal | Resolution:
Keywords: staticfiles | Triage Stage: Ready for
middleware_chain | checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Claude Paroz):
Replying to [comment:7 koxu1996]:
> BTW do you know why there is 404 error? Should not be ''/static'' served
even though STATICFILES_DIRS is not set and no files are collected?
No, `StaticFilesHandler` is only serving "uncollected" files, as its
typical use case is to serve static files during developement, not in a
deployed environment.
--
Ticket URL: <https://code.djangoproject.com/ticket/29353#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: koxu1996 | Owner: Claude
| Paroz
Component: contrib.staticfiles | Version: 2.0
Severity: Normal | Resolution: fixed
Keywords: staticfiles | Triage Stage: Ready for
middleware_chain | checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"a9189d27efccdee0b5e8b84f69f9041176055769" a9189d27]:
{{{
#!CommitTicketReference repository=""
revision="a9189d27efccdee0b5e8b84f69f9041176055769"
Fixed #29353 -- Made StaticFilesHandler return a 404 response when
settings.DEBUG is False
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29353#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: koxu1996 | Owner: Claude
| Paroz
Type: Bug | Status: closed
Component: contrib.staticfiles | Version: 2.0
Severity: Normal | Resolution: fixed
Keywords: staticfiles | Triage Stage: Ready for
middleware_chain | checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson <carlton.gibson@…>):
In [changeset:"1fac9740675b8dbea3952b58102a643c67e951e4" 1fac974]:
{{{
#!CommitTicketReference repository=""
revision="1fac9740675b8dbea3952b58102a643c67e951e4"
Refs #29353 -- Removed duplicated logic in
StaticFilesHandler.get_response().
Thanks Sergey Fursov for spotting the issue.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29353#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: koxu1996 | Owner: Claude
| Paroz
Type: Bug | Status: closed
Component: contrib.staticfiles | Version: 2.0
Severity: Normal | Resolution: fixed
Keywords: staticfiles | Triage Stage: Ready for
middleware_chain | checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"add57c7e27fa36be8ebec4df4a2cbad81e318070" add57c7e]:
{{{
#!CommitTicketReference repository=""
revision="add57c7e27fa36be8ebec4df4a2cbad81e318070"
[2.1.x] Refs #29353 -- Removed duplicated logic in
StaticFilesHandler.get_response().
Thanks Sergey Fursov for spotting the issue.
Backport of 1fac9740675b8dbea3952b58102a643c67e951e4 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29353#comment:12>