[Django] #27616: HTTP_X_REQUESTED_WITH should be X-Requested-With in request-response.txt

Django

unread,

Dec 20, 2016, 1:21:39 AM12/20/16

to django-...@googlegroups.com

#27616: HTTP_X_REQUESTED_WITH should be X-Requested-With in request-response.txt
-----------------------------------------+------------------------
Reporter: dhoulder | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-----------------------------------------+------------------------
docs/ref/request-response.txt suggests calling
{{{
vary_on_headers('HTTP_X_REQUESTED_WITH')
}}}
but that results in the HTTP response containing
{{{
Vary: HTTP_X_REQUESTED_WITH,Cookie
}}}
instead of
{{{
Vary: X-Requested-With,Cookie
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27616>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Dec 20, 2016, 1:23:51 AM12/20/16

to django-...@googlegroups.com

#27616: HTTP_X_REQUESTED_WITH should be X-Requested-With in request-response.txt

-------------------------------+--------------------------------------

Reporter: dhoulder | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: master

Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

-------------------------------+--------------------------------------
Changes (by dhoulder):

* Attachment "request-response.diff" added.

Django

unread,

Dec 20, 2016, 8:30:55 AM12/20/16

to django-...@googlegroups.com

#27616: HTTP_X_REQUESTED_WITH should be X-Requested-With in request-response.txt

-------------------------------+--------------------------------------
Reporter: David Houlder | Owner: nobody
Type: Uncategorized | Status: closed
Component: Uncategorized | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

-------------------------------+--------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"5e239ae907291d07a3fcf9329f83c27fa6d72981" 5e239ae]:
{{{
#!CommitTicketReference repository=""
revision="5e239ae907291d07a3fcf9329f83c27fa6d72981"
Fixed #27616 -- Fixed incorrect vary_on_headers() example.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27616#comment:1>

Django

unread,

Dec 20, 2016, 8:32:23 AM12/20/16

to django-...@googlegroups.com

#27616: HTTP_X_REQUESTED_WITH should be X-Requested-With in request-response.txt

-------------------------------+--------------------------------------
Reporter: David Houlder | Owner: nobody
Type: Uncategorized | Status: closed
Component: Uncategorized | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

-------------------------------+--------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"7418690bf71da5ce9b6bdab6086515c2763b5820" 7418690b]:
{{{
#!CommitTicketReference repository=""
revision="7418690bf71da5ce9b6bdab6086515c2763b5820"
[1.9.x] Fixed #27616 -- Fixed incorrect vary_on_headers() example.

Backport of 5e239ae907291d07a3fcf9329f83c27fa6d72981 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27616#comment:2>

Django

unread,

Dec 20, 2016, 8:32:26 AM12/20/16

to django-...@googlegroups.com

#27616: HTTP_X_REQUESTED_WITH should be X-Requested-With in request-response.txt

-------------------------------+--------------------------------------
Reporter: David Houlder | Owner: nobody
Type: Uncategorized | Status: closed
Component: Uncategorized | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

-------------------------------+--------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"c9ba3450bd03c9c8822dcf5570b0fcf5d08d9467" c9ba345]:
{{{
#!CommitTicketReference repository=""
revision="c9ba3450bd03c9c8822dcf5570b0fcf5d08d9467"
[1.8.x] Fixed #27616 -- Fixed incorrect vary_on_headers() example.

Backport of 5e239ae907291d07a3fcf9329f83c27fa6d72981 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27616#comment:3>

Django

unread,

Dec 20, 2016, 8:32:46 AM12/20/16

to django-...@googlegroups.com

#27616: HTTP_X_REQUESTED_WITH should be X-Requested-With in request-response.txt

-------------------------------+--------------------------------------
Reporter: David Houlder | Owner: nobody
Type: Uncategorized | Status: closed
Component: Uncategorized | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

-------------------------------+--------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"54cce02ddd8037554c88f0becffe9bc4d33093e7" 54cce02]:
{{{
#!CommitTicketReference repository=""
revision="54cce02ddd8037554c88f0becffe9bc4d33093e7"
[1.10.x] Fixed #27616 -- Fixed incorrect vary_on_headers() example.