[Django] #30347: A typo in Aggregation document.

8 views
Skip to first unread message

Django

unread,
Apr 11, 2019, 3:45:07 AM4/11/19
to django-...@googlegroups.com
#30347: A typo in Aggregation document.
-----------------------------------------+------------------------
Reporter: tpzstamp | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 2.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
In the online document, **Using Django** -> **Models and databases** ->
**Aggregation** page,
section **Filtering on annotations**,
[https://docs.djangoproject.com/en/2.2/topics/db/aggregation/#filtering-
on-annotations]

The original text is
{{{
>>> highly_rated = Count('books', filter=Q(books__rating__gte=7))
>>> Author.objects.annotate(num_books=Count('books'),
highly_rated_books=highly_rated)
}}}

Here, should 'books' be 'book' in these two lines?

--
Ticket URL: <https://code.djangoproject.com/ticket/30347>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 11, 2019, 4:26:10 AM4/11/19
to django-...@googlegroups.com
#30347: A typo in Aggregation document.
--------------------------------------+------------------------------------
Reporter: PM | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 2.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by felixxm):

* type: Uncategorized => Cleanup/optimization
* easy: 0 => 1
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/30347#comment:1>

Django

unread,
Apr 11, 2019, 10:05:30 AM4/11/19
to django-...@googlegroups.com
#30347: A typo in Aggregation document.
-------------------------------------+-------------------------------------
Reporter: PM | Owner:
Type: | phillipahereza
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 2.2

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by phillipahereza):

* status: new => assigned
* owner: nobody => phillipahereza


--
Ticket URL: <https://code.djangoproject.com/ticket/30347#comment:2>

Django

unread,
Apr 13, 2019, 6:00:52 AM4/13/19
to django-...@googlegroups.com
#30347: A typo in Aggregation document.
-------------------------------------+-------------------------------------
Reporter: PM | Owner: Daniel
Type: | Musketa
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 2.2

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Daniel Musketa):

* owner: Phillip Ahereza => Daniel Musketa


Comment:

https://github.com/django/django/pull/11204

--
Ticket URL: <https://code.djangoproject.com/ticket/30347#comment:3>

Django

unread,
Apr 13, 2019, 6:22:04 AM4/13/19
to django-...@googlegroups.com
#30347: A typo in Aggregation document.
-------------------------------------+-------------------------------------
Reporter: PM | Owner: Daniel
Type: | Musketa
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 2.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/30347#comment:4>

Django

unread,
Apr 13, 2019, 6:36:25 AM4/13/19
to django-...@googlegroups.com
#30347: A typo in Aggregation document.
-------------------------------------+-------------------------------------
Reporter: PM | Owner: Daniel
Type: | Musketa
Cleanup/optimization | Status: closed
Component: Documentation | Version: 2.2
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"ba726067604ce5a8ca3919edf653496722b433ab" ba726067]:
{{{
#!CommitTicketReference repository=""
revision="ba726067604ce5a8ca3919edf653496722b433ab"
Fixed #30347 -- Fixed typo in docs/topics/db/aggregation.txt.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30347#comment:5>

Django

unread,
Apr 13, 2019, 6:37:27 AM4/13/19
to django-...@googlegroups.com
#30347: A typo in Aggregation document.
-------------------------------------+-------------------------------------
Reporter: PM | Owner: Daniel
Type: | Musketa
Cleanup/optimization | Status: closed
Component: Documentation | Version: 2.2

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"f5c1d02f13a0484f1c32caf1a0117f1e75a3dc8f" f5c1d02f]:
{{{
#!CommitTicketReference repository=""
revision="f5c1d02f13a0484f1c32caf1a0117f1e75a3dc8f"
[2.2.x] Fixed #30347 -- Fixed typo in docs/topics/db/aggregation.txt.

Backport of ba726067604ce5a8ca3919edf653496722b433ab from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30347#comment:6>

Reply all
Reply to author
Forward
0 new messages