[Django] #27357: Variant of FilePathField that uses a Storage backend

6 views
Skip to first unread message

Django

unread,
Oct 17, 2016, 7:57:45 PM10/17/16
to django-...@googlegroups.com
#27357: Variant of FilePathField that uses a Storage backend
-------------------------------------+-------------------------------------
Reporter: Curtis | Owner: nobody
Maloney |
Type: New | Status: new
feature |
Component: Database | Version: 1.10
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 1 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-------------------------------------+-------------------------------------
It seems inconsistent that our FilePathField doesn't use abstracted
storage unlike pretty much all other file access.

--
Ticket URL: <https://code.djangoproject.com/ticket/27357>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 17, 2016, 8:21:10 PM10/17/16
to django-...@googlegroups.com
#27357: Variant of FilePathField that uses a Storage backend
-------------------------------------+-------------------------------------
Reporter: Curtis Maloney | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* needs_docs: 1 => 0


Comment:

The `FilePathField` form field looks coupled to the file system
(`os.walk()`, etc). Maybe it would be enough to try to add a storage
agnostic file path form field and allow developers to use it with
`models.FileField`. While `models.FilePathField` takes `path`, `math`,
`recursive`, `allow_files`, and `allow_folders` arguments, it's not doing
anything with them besides passing them to the form field.

--
Ticket URL: <https://code.djangoproject.com/ticket/27357#comment:1>

Django

unread,
Oct 22, 2016, 6:55:25 PM10/22/16
to django-...@googlegroups.com
#27357: Variant of FilePathField that uses a Storage backend
-------------------------------------+-------------------------------------
Reporter: Curtis Maloney | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Accepted


Comment:

Tentatively accepting, though a design proposal and a description of the
use case is needed.

--
Ticket URL: <https://code.djangoproject.com/ticket/27357#comment:2>

Reply all
Reply to author
Forward
0 new messages