[Django] #31607: Subquery.__eq__() doesn't work properly for resolved subqueries.

7 views
Skip to first unread message

Django

unread,
May 19, 2020, 5:25:11 AM5/19/20
to django-...@googlegroups.com
#31607: Subquery.__eq__() doesn't work properly for resolved subqueries.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: Database | Version: 3.1
layer (models, ORM) |
Severity: Release | Keywords:
blocker |
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
`Subquery.__eq__()` doesn't work properly for resolved subqueries,
basically all resolved subqueries are now equal.

Regression in 691def10a0197d83d2d108bd9043b0916d0f09b4.

--
Ticket URL: <https://code.djangoproject.com/ticket/31607>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 19, 2020, 5:26:17 AM5/19/20
to django-...@googlegroups.com
#31607: Subquery.__eq__() doesn't work properly for resolved subqueries.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: Database layer | Version: 3.1
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* Attachment "test-31607.diff" added.

Regression test.

Django

unread,
May 19, 2020, 6:34:10 AM5/19/20
to django-...@googlegroups.com
#31607: Subquery.__eq__() doesn't work properly for resolved subqueries.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: Database layer | Version: 3.1
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/12936 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/31607#comment:1>

Django

unread,
May 19, 2020, 4:45:20 PM5/19/20
to django-...@googlegroups.com
#31607: Subquery.__eq__() doesn't work properly for resolved subqueries.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: closed

Component: Database layer | Version: 3.1
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"a125da6a7c79b1d4c55677d0bed6f9b1d7d77353" a125da6a]:
{{{
#!CommitTicketReference repository=""
revision="a125da6a7c79b1d4c55677d0bed6f9b1d7d77353"
Fixed #31607 -- Fixed evaluated Subquery equality.

Regression in 691def10a0197d83d2d108bd9043b0916d0f09b4.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31607#comment:2>

Django

unread,
May 19, 2020, 4:49:29 PM5/19/20
to django-...@googlegroups.com
#31607: Subquery.__eq__() doesn't work properly for resolved subqueries.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: closed
Component: Database layer | Version: 3.0

(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* version: 3.1 => 3.0
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/31607#comment:3>

Django

unread,
May 19, 2020, 4:51:11 PM5/19/20
to django-...@googlegroups.com
#31607: Subquery.__eq__() doesn't work properly for resolved subqueries.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: closed
Component: Database layer | Version: 3.0
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"937314dc05ee06eca91fcbb3ddf4380a60275b59" 937314d]:
{{{
#!CommitTicketReference repository=""
revision="937314dc05ee06eca91fcbb3ddf4380a60275b59"
[3.1.x] Fixed #31607 -- Fixed evaluated Subquery equality.

Regression in 691def10a0197d83d2d108bd9043b0916d0f09b4.

Backport of a125da6a7c79b1d4c55677d0bed6f9b1d7d77353 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31607#comment:4>

Django

unread,
May 19, 2020, 4:51:37 PM5/19/20
to django-...@googlegroups.com
#31607: Subquery.__eq__() doesn't work properly for resolved subqueries.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: closed
Component: Database layer | Version: 3.0
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"0ba5aadb3377e49e995753944a7e5e55c3840bed" 0ba5aadb]:
{{{
#!CommitTicketReference repository=""
revision="0ba5aadb3377e49e995753944a7e5e55c3840bed"
[3.0.x] Fixed #31607 -- Fixed evaluated Subquery equality.

Regression in 691def10a0197d83d2d108bd9043b0916d0f09b4.

Backport of a125da6a7c79b1d4c55677d0bed6f9b1d7d77353 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31607#comment:5>

Django

unread,
May 20, 2020, 3:18:42 AM5/20/20
to django-...@googlegroups.com
#31607: Subquery.__eq__() doesn't work properly for resolved subqueries.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: closed
Component: Database layer | Version: 3.0
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by GitHub <noreply@…>):

In [changeset:"8328811f048fed0dd22573224def8c65410c9f2e" 8328811]:
{{{
#!CommitTicketReference repository=""
revision="8328811f048fed0dd22573224def8c65410c9f2e"
Refs #31607 -- Added release notes for
a125da6a7c79b1d4c55677d0bed6f9b1d7d77353.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31607#comment:6>

Django

unread,
May 20, 2020, 3:19:49 AM5/20/20
to django-...@googlegroups.com
#31607: Subquery.__eq__() doesn't work properly for resolved subqueries.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: closed
Component: Database layer | Version: 3.0
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"d5231719e0ec86dc6b71487e5461b34bac1c55f6" d5231719]:
{{{
#!CommitTicketReference repository=""
revision="d5231719e0ec86dc6b71487e5461b34bac1c55f6"
[3.1.x] Refs #31607 -- Added release notes for
a125da6a7c79b1d4c55677d0bed6f9b1d7d77353.

Backport of 8328811f048fed0dd22573224def8c65410c9f2e from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31607#comment:7>

Django

unread,
May 20, 2020, 3:20:12 AM5/20/20
to django-...@googlegroups.com
#31607: Subquery.__eq__() doesn't work properly for resolved subqueries.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: closed
Component: Database layer | Version: 3.0
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"52453b438a190f3f91fb0b19dee6184f91b176eb" 52453b4]:
{{{
#!CommitTicketReference repository=""
revision="52453b438a190f3f91fb0b19dee6184f91b176eb"
[3.0.x] Refs #31607 -- Added release notes for
a125da6a7c79b1d4c55677d0bed6f9b1d7d77353.

Backport of 8328811f048fed0dd22573224def8c65410c9f2e from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31607#comment:8>

Reply all
Reply to author
Forward
0 new messages