* status: closed => new
* resolution: fixed =>
Comment:
I believe the next step is to come up with a compatibility table of all
supported database types and which lookups we want to support.
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:50>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
* cc: felixxm (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:51>
* owner: nobody => sage
* status: new => assigned
Comment:
I will be working on this ticket during Google Summer of Code 2019.
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:52>
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
* needs_docs: 0 => 1
Comment:
[https://github.com/django/django/pull/11452 PR].
Please note that it's still a draft and I haven't implemented custom
lookups and transforms. More info on the PR's description.
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:53>
* needs_better_patch: 1 => 0
* needs_docs: 1 => 0
Comment:
The implementation is pretty much complete now, and docs have also been
added.
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:54>
* cc: Giacomo Graziosi (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:55>
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"6f82df69efa372fb4bddf272fff577850a09f1dc" 6f82df6]:
{{{
#!CommitTicketReference repository=""
revision="6f82df69efa372fb4bddf272fff577850a09f1dc"
Refs #12990 -- Moved CheckFieldDefaultMixin to the
django.db.models.fields.mixins.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:56>
Comment (by sage):
[https://github.com/django/django/pull/12392 PR].
Moved to a fresh one.
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:57>
Comment (by GitHub <noreply@…>):
In [changeset:"5c24c16e68868b33ea0bb30173403da51a078d2e" 5c24c16e]:
{{{
#!CommitTicketReference repository=""
revision="5c24c16e68868b33ea0bb30173403da51a078d2e"
Refs #12990 -- Moved PostgresSimpleLookup to the
django.db.models.lookups.PostgresOperatorLookup.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:58>
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:59>
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"6789ded0a6ab797f0dcdfa6ad5d1cfa46e23abcd" 6789ded0]:
{{{
#!CommitTicketReference repository=""
revision="6789ded0a6ab797f0dcdfa6ad5d1cfa46e23abcd"
Fixed #12990, Refs #27694 -- Added JSONField model field.
Thanks to Adam Johnson, Carlton Gibson, Mariusz Felisiak, and Raphael
Michel for mentoring this Google Summer of Code 2019 project and
everyone else who helped with the patch.
Special thanks to Mads Jensen, Nick Pope, and Simon Charette for
extensive reviews.
Co-authored-by: Mariusz Felisiak <felisiak...@gmail.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:61>
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"f97f71f59249f1fbeebe84d4fc858d70fc456f7d" f97f71f5]:
{{{
#!CommitTicketReference repository=""
revision="f97f71f59249f1fbeebe84d4fc858d70fc456f7d"
Refs #12990 -- Bumped mysqlclient requirement to >= 1.4.0.
MySQLdb.constants.FIELD_TYPE.JSON was added in mysqlclient 1.4.0rc2.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:60>
Comment (by GitHub <noreply@…>):
In [changeset:"f59a2b730685fc62c5cb44101f54faf8921d9bc7" f59a2b73]:
{{{
#!CommitTicketReference repository=""
revision="f59a2b730685fc62c5cb44101f54faf8921d9bc7"
Refs #12990 -- Added DatabaseFeatures.has_json_operators.
CockroachDB also has them.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:62>
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"5480fab290655682db7fc12c087675df43115a01" 5480fab2]:
{{{
#!CommitTicketReference repository=""
revision="5480fab290655682db7fc12c087675df43115a01"
[3.1.x] Refs #12990 -- Added DatabaseFeatures.has_json_operators.
CockroachDB also has them.
Backport of f59a2b730685fc62c5cb44101f54faf8921d9bc7 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:63>
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"5d4b9c1cab03f0d057f0c7751862df0302c65cf9" 5d4b9c1c]:
{{{
#!CommitTicketReference repository=""
revision="5d4b9c1cab03f0d057f0c7751862df0302c65cf9"
Refs #12990 -- Added example to JSONField release notes.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:64>
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"7598ba01aa2b0b48ac006aea6d218f77eb949061" 7598ba01]:
{{{
#!CommitTicketReference repository=""
revision="7598ba01aa2b0b48ac006aea6d218f77eb949061"
[3.1.x] Refs #12990 -- Added example to JSONField release notes.
Backport of 5d4b9c1cab03f0d057f0c7751862df0302c65cf9 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:65>
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"7cb5712edc158396c9d4fbf1ecf17794d9a128b3" 7cb5712]:
{{{
#!CommitTicketReference repository=""
revision="7cb5712edc158396c9d4fbf1ecf17794d9a128b3"
Refs #12990 -- Removed django.contrib.postgres.fields.JSONField per
deprecation timeline.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:66>
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"2dd6a83d2d7c61321ac4a9b10fbf3c379cb305c3" 2dd6a83]:
{{{
#!CommitTicketReference repository=""
revision="2dd6a83d2d7c61321ac4a9b10fbf3c379cb305c3"
Refs #12990 -- Removed django.contrib.postgres.forms.JSONField per
deprecation timeline.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:68>
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"8fdb5a656a35dc9beef4cf2b79a782068263c7ec" 8fdb5a65]:
{{{
#!CommitTicketReference repository=""
revision="8fdb5a656a35dc9beef4cf2b79a782068263c7ec"
Refs #12990 -- Removed
django.contrib.postgres.fields.jsonb.KeyTransform/KeyTextTransform.
Per deprecation timeline.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12990#comment:67>