[Django] #27324: Simplify get_constraints on Oracle
Django
----------------------------------------------+----------------------
Reporter: felixxm | Owner: felixxm
Type: Cleanup/optimization | Status: assigned
Component: Database layer (models, ORM) | Version: master
Severity: Normal | Keywords: oracle
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------------------+----------------------
I propose to remove unnecessary sql with check constraints
([https://github.com/django/django/blob/master/django/db/backends/oracle/introspection.py#L207
1]) and optimization of another one that will return PKs, uniques and
checks
([https://github.com/django/django/blob/master/django/db/backends/oracle/introspection.py#L163
2]) in
[https://github.com/django/django/blob/master/django/db/backends/oracle/introspection.py#L156
get_constraints] on Oracle.
--
Ticket URL: <https://code.djangoproject.com/ticket/27324>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: felixxm | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage:
| Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* needs_better_patch: => 0
* has_patch: 0 => 1
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/27324#comment:1>
Django
Reporter: felixxm | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Simon Charette):
* stage: Unreviewed => Accepted
Comment:
[https://github.com/django/django/pull/7359 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/27324#comment:2>
Django
Reporter: felixxm | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* stage: Accepted => Ready for checkin
Comment:
Looks good, pending feedback from anyone interested in Oracle.
--
Ticket URL: <https://code.djangoproject.com/ticket/27324#comment:3>
Django
Reporter: felixxm | Owner: felixxm
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Keywords: oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"5a772a0b7bf71128287396d310ddd3db13625a1f" 5a772a0]:
{{{
#!CommitTicketReference repository=""
revision="5a772a0b7bf71128287396d310ddd3db13625a1f"
Fixed #27324 -- Simplified DatabaseIntrospection.get_constraints() on
Oracle.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27324#comment:4>
Django
Reporter: felixxm | Owner: felixxm
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"2d259e6badf032fbdc41f4a2c96a545a94a9ec91" 2d259e6]:
{{{
#!CommitTicketReference repository=""
revision="2d259e6badf032fbdc41f4a2c96a545a94a9ec91"
Refs #27324 -- Optimized DatabaseIntrospection.get_constraints() for
foreign keys on Oracle.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27324#comment:5>