[Django] #29523: Remove DateTimeShortcuts.js dependency on jQuery

45 views
Skip to first unread message

Django

unread,
Jun 25, 2018, 6:24:24 AM6/25/18
to django-...@googlegroups.com
#29523: Remove DateTimeShortcuts.js dependency on jQuery
------------------------------------------------+------------------------
Reporter: Claude Paroz | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
DateTimeShortcuts.js is only marginally depending on jQuery, so I think a
pure JavaScript implementation would be trivial to achieve.

--
Ticket URL: <https://code.djangoproject.com/ticket/29523>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 25, 2018, 6:41:01 AM6/25/18
to django-...@googlegroups.com
#29523: Remove DateTimeShortcuts.js dependency on jQuery
--------------------------------------+------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by felixxm):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/29523#comment:1>

Django

unread,
Jun 25, 2018, 3:32:09 PM6/25/18
to django-...@googlegroups.com
#29523: Remove DateTimeShortcuts.js dependency on jQuery
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Srinivas
Type: | Reddy Thatiparthy
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Srinivas Reddy Thatiparthy):

* owner: nobody => Srinivas Reddy Thatiparthy
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/29523#comment:2>

Django

unread,
Jun 25, 2018, 4:07:28 PM6/25/18
to django-...@googlegroups.com
#29523: Remove DateTimeShortcuts.js dependency on jQuery
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Srinivas
Type: | Reddy Thatiparthy
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz):

There is a [https://github.com/django/django/pull/10092 PR] already,
albeit with test failures.

--
Ticket URL: <https://code.djangoproject.com/ticket/29523#comment:3>

Django

unread,
Jun 25, 2018, 9:49:10 PM6/25/18
to django-...@googlegroups.com
#29523: Remove DateTimeShortcuts.js dependency on jQuery
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Srinivas
Type: | Reddy Thatiparthy
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* needs_better_patch: 0 => 1
* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/29523#comment:4>

Django

unread,
Jun 30, 2018, 7:55:31 AM6/30/18
to django-...@googlegroups.com
#29523: Remove DateTimeShortcuts.js dependency on jQuery
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Srinivas
Type: | Reddy Thatiparthy
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/29523#comment:5>

Django

unread,
Jun 30, 2018, 4:21:42 PM6/30/18
to django-...@googlegroups.com
#29523: Remove DateTimeShortcuts.js dependency on jQuery
--------------------------------------+------------------------------------
Reporter: Claude Paroz | Owner: (none)

Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Changes (by Srinivas Reddy Thatiparthy):

* status: assigned => new
* owner: Srinivas Reddy Thatiparthy => (none)


--
Ticket URL: <https://code.djangoproject.com/ticket/29523#comment:6>

Django

unread,
Jul 20, 2018, 3:10:38 PM7/20/18
to django-...@googlegroups.com
#29523: Remove DateTimeShortcuts.js dependency on jQuery
--------------------------------------+------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"ba83378a7762c51be235b521aa5b48233d6c6c82" ba83378a]:
{{{
#!CommitTicketReference repository=""
revision="ba83378a7762c51be235b521aa5b48233d6c6c82"
Fixed #29523 -- Removed jQuery usage in DateTimeShortcuts.js &
collapse.js.
}}}

Django

unread,
Feb 27, 2019, 4:28:57 PM2/27/19
to django-...@googlegroups.com
#29523: Remove DateTimeShortcuts.js dependency on jQuery
--------------------------------------+------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: contrib.admin | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"93e892bb645b16ebaf287beb5fe7f3ffe8d10408" 93e892bb]:
{{{
#!CommitTicketReference repository=""
revision="93e892bb645b16ebaf287beb5fe7f3ffe8d10408"
Refs #29523 -- Updated admin's collapse.min.js.

Omitted in ba83378a7762c51be235b521aa5b48233d6c6c82.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29523#comment:7>

Django

unread,
Feb 27, 2019, 4:34:29 PM2/27/19
to django-...@googlegroups.com
#29523: Remove DateTimeShortcuts.js dependency on jQuery
--------------------------------------+------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: contrib.admin | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"d29c8ea124d4c19e23f73b8a307dd177d8a1fe7b" d29c8ea1]:
{{{
#!CommitTicketReference repository=""
revision="d29c8ea124d4c19e23f73b8a307dd177d8a1fe7b"
[2.2.x] Refs #29523 -- Updated admin's collapse.min.js.

Omitted in ba83378a7762c51be235b521aa5b48233d6c6c82.

Backport of 93e892bb645b16ebaf287beb5fe7f3ffe8d10408 from master.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29523#comment:8>

Reply all
Reply to author
Forward
0 new messages