[Django] #32389: ResponseHeaders initialization crashes when provided data is an iterable of tuple pairs
Django
tuple pairs
------------------------------------------+--------------------------------
Reporter: Illia Volochii | Owner: Illia Volochii
Type: Bug | Status: assigned
Component: Uncategorized | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------+--------------------------------
{{{
>>> from django.http.response import ResponseHeaders
>>> headers = ResponseHeaders((('X-Foo', 'bar'),))
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "[...]/django/django/http/response.py", line 36, in __init__
for k, v in
CaseInsensitiveMapping._destruct_iterable_mapping_values(data)
AttributeError: type object 'CaseInsensitiveMapping' has no attribute
'_destruct_iterable_mapping_values'
}}}
`_destruct_iterable_mapping_values` is used as a method of
`CaseInsensitiveMapping`, but it is a separate function.
--
Ticket URL: <https://code.djangoproject.com/ticket/32389>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: Illia Volochii | Owner: Illia
| Volochii
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* severity: Normal => Release blocker
* cc: Tom Carrick (added)
* component: Uncategorized => HTTP handling
* version: master => 3.2
* stage: Unreviewed => Accepted
Comment:
Thanks, good catch. [https://github.com/django/django/pull/13940 PR]
Bug in bcc2befd0e9c1885e45b46d0b0bcdc11def8b249.
--
Ticket URL: <https://code.djangoproject.com/ticket/32389#comment:1>
Django
-------------------------------------+-------------------------------------
| Volochii
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/32389#comment:2>
Django
-------------------------------------+-------------------------------------
| Volochii
Component: HTTP handling | Version: 3.2
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson <carlton@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"3c004075b1d4fe4aa1ffc3f7d699dd9525bc6c02" 3c004075]:
{{{
#!CommitTicketReference repository=""
revision="3c004075b1d4fe4aa1ffc3f7d699dd9525bc6c02"
Fixed #32389 -- Fixed ResponseHeaders crash when data is not mapping.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32389#comment:3>
Django
-------------------------------------+-------------------------------------
| Volochii
Component: HTTP handling | Version: 3.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson <carlton.gibson@…>):
In [changeset:"f9b2b1bb3bc4381752dd85a5f962202a0cc5cbb6" f9b2b1bb]:
{{{
#!CommitTicketReference repository=""
revision="f9b2b1bb3bc4381752dd85a5f962202a0cc5cbb6"
[3.2.x] Fixed #32389 -- Fixed ResponseHeaders crash when data is not
mapping.
Backport of 3c004075b1d4fe4aa1ffc3f7d699dd9525bc6c02 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32389#comment:4>