[Django] #27302: Date/time fields flagged as changed in ModelAdmin.construct_change_message

4 views
Skip to first unread message

Django

unread,
Oct 1, 2016, 1:28:21 PM10/1/16
to django-...@googlegroups.com
#27302: Date/time fields flagged as changed in ModelAdmin.construct_change_message
-------------------------------------------+------------------------
Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.10
Severity: Release blocker | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
Reported on IRC by Ramiro Morales: When a ModelAdmin uses a localized
date/time input, the matching fields are always flagged as changed when
populating the change message for the LogEntry.
Bisected to [cf7894be88f6c27680ef80796b883f6e3b709b8b].

--
Ticket URL: <https://code.djangoproject.com/ticket/27302>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 1, 2016, 1:36:32 PM10/1/16
to django-...@googlegroups.com
#27302: Date/time fields flagged as changed in ModelAdmin.construct_change_message
---------------------------------+------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.10
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Claude Paroz):

* has_patch: 0 => 1


Comment:

https://github.com/django/django/pull/7331

--
Ticket URL: <https://code.djangoproject.com/ticket/27302#comment:1>

Django

unread,
Oct 1, 2016, 2:15:43 PM10/1/16
to django-...@googlegroups.com
#27302: Date/time fields flagged as changed in ModelAdmin.construct_change_message
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.10
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/27302#comment:2>

Django

unread,
Oct 1, 2016, 2:15:46 PM10/1/16
to django-...@googlegroups.com
#27302: Date/time fields flagged as changed in ModelAdmin.construct_change_message
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.10
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"67eee5e4fa08f4404445ebf4f54b686e68a8530c" 67eee5e4]:
{{{
#!CommitTicketReference repository=""
revision="67eee5e4fa08f4404445ebf4f54b686e68a8530c"
Fixed #27302 -- Fixed ModelAdmin.construct_change_message() changed field
detection

Thanks Ramiro Morales for the report and Tim Graham for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27302#comment:3>

Django

unread,
Oct 1, 2016, 2:17:20 PM10/1/16
to django-...@googlegroups.com
#27302: Date/time fields flagged as changed in ModelAdmin.construct_change_message
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.10

Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"062b8ba37e616a70d131dcec5f3a760d8d1ceb2c" 062b8ba3]:
{{{
#!CommitTicketReference repository=""
revision="062b8ba37e616a70d131dcec5f3a760d8d1ceb2c"
[1.10.x] Fixed #27302 -- Fixed ModelAdmin.construct_change_message()
changed field detection

Thanks Ramiro Morales for the report and Tim Graham for the review.

Backport of 67eee5e4fa08f4404445ebf4f54b686e68a8530c from master.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27302#comment:4>

Reply all
Reply to author
Forward
0 new messages