[Django] #27174: Explicitly define where string comes from

8 views
Skip to first unread message

Django

unread,
Sep 3, 2016, 8:13:04 PM9/3/16
to django-...@googlegroups.com
#27174: Explicitly define where string comes from
--------------------------------------+--------------------
Reporter: hckrtst | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.10
Severity: Normal | Keywords: docs
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+--------------------
In tutorial02.txt, polls.apps.PollsConfig is introduced without much
explanation, which may be slightly confusing for first-time readers. It
would be good to have some explanation of why we use that specific string
in this context.

--
Ticket URL: <https://code.djangoproject.com/ticket/27174>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 3, 2016, 8:22:13 PM9/3/16
to django-...@googlegroups.com
#27174: Explicitly define where string comes from
-------------------------------------+-------------------------------------
Reporter: hckrtst | Owner: hckrtst
Type: | Status: assigned
Cleanup/optimization |
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:

Keywords: docs | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by hckrtst):

* owner: nobody => hckrtst
* status: new => assigned
* needs_docs: => 0
* needs_tests: => 0
* needs_better_patch: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/27174#comment:1>

Django

unread,
Sep 3, 2016, 8:33:39 PM9/3/16
to django-...@googlegroups.com
#27174: Explicitly define where string comes from
-------------------------------------+-------------------------------------
Reporter: hckrtst | Owner:
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:

Keywords: docs | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by hckrtst):

* owner: hckrtst =>
* status: assigned => new


--
Ticket URL: <https://code.djangoproject.com/ticket/27174#comment:2>

Django

unread,
Sep 4, 2016, 11:13:46 AM9/4/16
to django-...@googlegroups.com
#27174: Explicitly define where string comes from
-------------------------------------+-------------------------------------
Reporter: hckrtst | Owner: ankur0493
Type: | Status: assigned
Cleanup/optimization |
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:

Keywords: docs | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by ankur0493):

* owner: => ankur0493
* needs_docs: 0 => 1


* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/27174#comment:3>

Django

unread,
Sep 5, 2016, 2:14:48 AM9/5/16
to django-...@googlegroups.com
#27174: Explicitly define where string comes from
-------------------------------------+-------------------------------------
Reporter: hckrtst | Owner: ankur0493
Type: | Status: assigned
Cleanup/optimization |
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:

Keywords: docs | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by ankur0493):

Does someone reviews this or should I just make the change?

--
Ticket URL: <https://code.djangoproject.com/ticket/27174#comment:4>

Django

unread,
Sep 5, 2016, 6:45:31 AM9/5/16
to django-...@googlegroups.com
#27174: Explain where 'polls.apps.PollsConfig' comes from in tutorial 2

-------------------------------------+-------------------------------------
Reporter: hckrtst | Owner: ankur0493
Type: | Status: assigned
Cleanup/optimization |
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: docs | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_docs: 1 => 0
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/27174#comment:5>

Django

unread,
Sep 6, 2016, 2:24:59 AM9/6/16
to django-...@googlegroups.com
#27174: Explain where 'polls.apps.PollsConfig' comes from in tutorial 2
-------------------------------------+-------------------------------------
Reporter: hckrtst | Owner: ankur0493
Type: | Status: assigned
Cleanup/optimization |
Component: Documentation | Version: 1.10

Severity: Normal | Resolution:
Keywords: docs | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by ankur0493):

* has_patch: 0 => 1


Comment:

I have submitted a PR for this
(https://github.com/django/django/pull/7211).

This change also needs to be made back to Django 1.9. Can anyone help me
in how to backport documentation changes? Do I need to merge this change
with 1.9.x and 1.10.x branches?

--
Ticket URL: <https://code.djangoproject.com/ticket/27174#comment:6>

Django

unread,
Sep 7, 2016, 2:16:45 PM9/7/16
to django-...@googlegroups.com
#27174: Explain where 'polls.apps.PollsConfig' comes from in tutorial 2
-------------------------------------+-------------------------------------
Reporter: hckrtst | Owner: ankur0493
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 1.10
Severity: Normal | Resolution: fixed

Keywords: docs | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"40d501147176352b694ec8b67b09127b20193ad2" 40d50114]:
{{{
#!CommitTicketReference repository=""
revision="40d501147176352b694ec8b67b09127b20193ad2"
Fixed #27174 -- Explained where PollsConfig comes from in tutorial 2.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27174#comment:7>

Django

unread,
Sep 7, 2016, 2:17:02 PM9/7/16
to django-...@googlegroups.com
#27174: Explain where 'polls.apps.PollsConfig' comes from in tutorial 2
-------------------------------------+-------------------------------------
Reporter: hckrtst | Owner: ankur0493
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 1.10

Severity: Normal | Resolution: fixed
Keywords: docs | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"9a03d30d94a6924ffdcdcc58dce267485ca393a2" 9a03d30d]:
{{{
#!CommitTicketReference repository=""
revision="9a03d30d94a6924ffdcdcc58dce267485ca393a2"
[1.10.x] Fixed #27174 -- Explained where PollsConfig comes from in
tutorial 2.

Backport of 40d501147176352b694ec8b67b09127b20193ad2 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27174#comment:8>

Django

unread,
Sep 7, 2016, 2:24:46 PM9/7/16
to django-...@googlegroups.com
#27174: Explain where 'polls.apps.PollsConfig' comes from in tutorial 2
-------------------------------------+-------------------------------------
Reporter: hckrtst | Owner: ankur0493
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 1.10

Severity: Normal | Resolution: fixed
Keywords: docs | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by ankur0493):

Hi Tim,

This also needs to be backported for 1.9.x

--
Ticket URL: <https://code.djangoproject.com/ticket/27174#comment:9>

Django

unread,
Sep 7, 2016, 2:52:38 PM9/7/16
to django-...@googlegroups.com
#27174: Explain where 'polls.apps.PollsConfig' comes from in tutorial 2
-------------------------------------+-------------------------------------
Reporter: hckrtst | Owner: ankur0493
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 1.10

Severity: Normal | Resolution: fixed
Keywords: docs | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by timgraham):

We don't update older versions of the docs except for critical mistakes.

--
Ticket URL: <https://code.djangoproject.com/ticket/27174#comment:10>

Reply all
Reply to author
Forward
0 new messages