[Django] #27723: `type` is not propagated correctly to widgets in MultiWidgets
Django
--------------------------------------+--------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: Forms | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------+--------------------------
If `type` is passed in `attrs` to `MultiWidget` then input HTML is
incorrect e.g.:
{{{
<input name="date_0" type="date" type="text" />
}}}
instead of
{{{
<input name="date_0" type="date" />
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27723>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: Forms | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* Attachment "27723.diff" added.
Django
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: Forms | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by felixxm):
It's a regression in #15667 that only affects master.
--
Ticket URL: <https://code.djangoproject.com/ticket/27723#comment:1>
Django
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: Forms | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/7835 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/27723#comment:2>
Django
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: Forms | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* needs_better_patch: 0 => 1
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
Comment:
In earlier versions of Django, passing `attrs` doesn't override the `type`
in subwidgets. Solving #5851 to allow different `attrs` for different
subwidgets might be a better solution.
--
Ticket URL: <https://code.djangoproject.com/ticket/27723#comment:3>
Django
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: Forms | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/27723#comment:4>
Django
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: closed
Component: Forms | Version: master
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"974d14534ca6bc12352c08576af5628e3f042652" 974d1453]:
{{{
#!CommitTicketReference repository=""
revision="974d14534ca6bc12352c08576af5628e3f042652"
Fixed #27723 -- Set MultiWidget's subwidgets input type from attrs
argument.
Regression in b52c73008a9d67e9ddbb841872dc15cdd3d6ee01.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27723#comment:5>