[Django] #28097: Strange layout of password widget in user admin

4 views
Skip to first unread message

Django

unread,
Apr 19, 2017, 5:14:39 AM4/19/17
to django-...@googlegroups.com
#28097: Strange layout of password widget in user admin
-------------------------------------------+------------------------
Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.11
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
With the new template-based widget rendering, the admin password widget
display is a bit awkward. See attached screenshot. Also, I'm not sure if
the the nesting of divs is wanted.

--
Ticket URL: <https://code.djangoproject.com/ticket/28097>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 19, 2017, 5:14:57 AM4/19/17
to django-...@googlegroups.com
#28097: Strange layout of password widget in user admin
---------------------------------+--------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.11
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by Claude Paroz):

* Attachment "admin_password_widget.png" added.

Django

unread,
Apr 19, 2017, 5:15:41 AM4/19/17
to django-...@googlegroups.com
#28097: Strange layout of password widget in user admin
---------------------------------+--------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.11
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------

Comment (by Aymeric Augustin):

This looks like a regression to me.

--
Ticket URL: <https://code.djangoproject.com/ticket/28097#comment:1>

Django

unread,
Apr 19, 2017, 8:58:01 AM4/19/17
to django-...@googlegroups.com
#28097: Incorrect layout of ReadOnlyPasswordHashWidget widget in user admin
---------------------------------+--------------------------------------
Reporter: Claude Paroz | Owner: Tim Graham
Type: Bug | Status: assigned
Component: contrib.auth | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by Tim Graham):

* owner: nobody => Tim Graham
* status: new => assigned
* stage: Unreviewed => Accepted
* component: contrib.admin => contrib.auth


--
Ticket URL: <https://code.djangoproject.com/ticket/28097#comment:2>

Django

unread,
Apr 19, 2017, 9:25:53 AM4/19/17
to django-...@googlegroups.com
#28097: Incorrect layout of ReadOnlyPasswordHashWidget widget in user admin
---------------------------------+--------------------------------------
Reporter: Claude Paroz | Owner: Tim Graham
Type: Bug | Status: assigned
Component: contrib.auth | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by Tim Graham):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/8376 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28097#comment:3>

Django

unread,
Apr 19, 2017, 12:26:44 PM4/19/17
to django-...@googlegroups.com
#28097: Incorrect layout of ReadOnlyPasswordHashWidget widget in user admin
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: Tim
| Graham
Type: Bug | Status: assigned
Component: contrib.auth | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* stage: Accepted => Ready for checkin


Comment:

Thanks for the fix!

--
Ticket URL: <https://code.djangoproject.com/ticket/28097#comment:4>

Django

unread,
Apr 19, 2017, 12:59:48 PM4/19/17
to django-...@googlegroups.com
#28097: Incorrect layout of ReadOnlyPasswordHashWidget widget in user admin
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Tim
| Graham
Type: Bug | Status: closed
Component: contrib.auth | Version: 1.11
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"dff559ff83a6aac14de0bbca58101786edf4195f" dff559f]:
{{{
#!CommitTicketReference repository=""
revision="dff559ff83a6aac14de0bbca58101786edf4195f"
Fixed #28097 -- Fixed layout of ReadOnlyPasswordHashWidget.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28097#comment:5>

Django

unread,
Apr 19, 2017, 1:09:13 PM4/19/17
to django-...@googlegroups.com
#28097: Incorrect layout of ReadOnlyPasswordHashWidget widget in user admin
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Tim
| Graham
Type: Bug | Status: closed
Component: contrib.auth | Version: 1.11
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"cf1e682c8c68d7187c34f46f2717b22f830d92a1" cf1e682]:
{{{
#!CommitTicketReference repository=""
revision="cf1e682c8c68d7187c34f46f2717b22f830d92a1"
[1.11.x] Fixed #28097 -- Fixed layout of ReadOnlyPasswordHashWidget.

Backport of dff559ff83a6aac14de0bbca58101786edf4195f from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28097#comment:6>

Reply all
Reply to author
Forward
0 new messages