[Django] #31576: Navigation sidebar hides some elements on small windows.
Django
-------------------------------------------+--------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+--------------------------
Navigation sidebar hides some elements, e.g. time/calendar pickers or
filter horizontal widgets.
--
Ticket URL: <https://code.djangoproject.com/ticket/31576>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.1
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* Attachment "Screenshot_20200513_100151.png" added.
Django
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.1
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* Attachment "Screenshot_20200513_095732.png" added.
Django
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.1
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by felixxm):
Proposed solution:
{{{
diff --git a/django/contrib/admin/static/admin/css/nav_sidebar.css
b/django/contrib/admin/static/admin/css/nav_sidebar.css
index 6fcfb26131..6968863e7c 100644
--- a/django/contrib/admin/static/admin/css/nav_sidebar.css
+++ b/django/contrib/admin/static/admin/css/nav_sidebar.css
@@ -93,7 +93,7 @@
background: #ffc;
}
-@media (max-width: 767px) {
+@media (max-width: 1024px) {
#nav-sidebar, #toggle-nav-sidebar {
display: none;
}
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31576#comment:1>
Django
Reporter: felixxm | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* cc: Tom Carrick (added)
* owner: felixxm => (none)
* status: assigned => new
Old description:
> Navigation sidebar hides some elements, e.g. time/calendar pickers or
> filter horizontal widgets.
New description:
Navigation sidebar hides some elements, e.g. time/calendar pickers or
filter horizontal widgets. It's a bug in a new feature, see #31034.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/31576#comment:2>
Django
Reporter: felixxm | Owner: (none)
Type: Bug | Status: new
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson):
I'm not sure that we need go as far as removing the sidebar for mid-sized
screens. Shutting the sidebar is sufficient to ''resolve'' the issue, and
it's a nice improvement.
Similar discussion on the PR:
[https://github.com/django/django/pull/12159#issuecomment-626703045 Tom],
[https://github.com/django/django/pull/12159#issuecomment-626711533
Mariusz]. That was to do with inline scrolling but with the same
conclusion, "...t can be mitigated by just closing it, so I think it's
alright from the user's perspective".
The error here only shows up on the selenium headless tests. Actually
using the admin on a 800px viewport is fine, great even: you just close
the sidebar if you don't want it.
I'm a bit reticent to loose it for the tablet sized screen for what seems
like a testing artifact. (We could either set a wider viewport in the
test, or ensure the sidebar is closed on a smaller screen, to be more
realistic.)
--
Ticket URL: <https://code.djangoproject.com/ticket/31576#comment:3>
Django
Reporter: felixxm | Owner: (none)
Type: Bug | Status: new
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* stage: Unreviewed => Accepted
Comment:
Going to accept though, as we either have to fix the test or disable the
feature.
--
Ticket URL: <https://code.djangoproject.com/ticket/31576#comment:4>
Django
Reporter: felixxm | Owner: (none)
Type: Bug | Status: new
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tom Carrick):
Couple of things:
This probably isn't the ''right'' fix, but it should be possible to fix
these tests by clicking the toggle after each request. This affects more
the tests than actual users, however (IMO).
I do plan on looking at all the various display issues on the currently
supported media queries between now and the non-blocking bug freeze, but I
won't assign this particular ticket to myself yet in case anyone has more
time before I get a chance to do that.
--
Ticket URL: <https://code.djangoproject.com/ticket/31576#comment:5>
Django
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.1
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* owner: (none) => felixxm
* status: new => assigned
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/12907 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/31576#comment:6>
Django
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: closed
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by GitHub <noreply@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"18eb852874a073001cb509f64002b6d82bdc760b" 18eb8528]:
{{{
#!CommitTicketReference repository=""
revision="18eb852874a073001cb509f64002b6d82bdc760b"
Fixed #31576 -- Fixed selenium tests with headless mode.
Horizontal scrollbar doesn't appear with the headless mode on small
windows, that's why window.scrollTo() is not an option for these
tests.
Tests changed after adding a navigation sidebar in
46fe506445666d8097945f0c1e8be11cfd644b28.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31576#comment:7>
Django
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: closed
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"e07887075707d7ac9c2cba358ed1adc88412a2c2" e078870]:
{{{
#!CommitTicketReference repository=""
revision="e07887075707d7ac9c2cba358ed1adc88412a2c2"
[3.1.x] Fixed #31576 -- Fixed selenium tests with headless mode.
Horizontal scrollbar doesn't appear with the headless mode on small
windows, that's why window.scrollTo() is not an option for these
tests.
Tests changed after adding a navigation sidebar in
46fe506445666d8097945f0c1e8be11cfd644b28.
Backport of 18eb852874a073001cb509f64002b6d82bdc760b from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31576#comment:8>