[Django] #31603: "Clear all filters" link removes ordering and search criteria.
Django
-------------------------------------------+------------------------
Reporter: felixxm | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
"Clear all filters" link removes ordering and search criteria, it should
clear only filters. It is a new feature added in Django 3.1 (see #27888
and b94764e178056a2118eff3f53f567207219e737d.
[https://groups.google.com/forum/?utm_source=digest&utm_medium=email#!topic
/django-developers/zrQSMqJsnRQ Discussion on the mailing list].
Thanks Fran Hrženjak for the report.
--
Ticket URL: <https://code.djangoproject.com/ticket/31603>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: felixxm | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 3.1
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Hasan Ramezani):
@felixxm
I've just created a [https://github.com/django/django/pull/12931 PR] to
fix this ticket. not sure about the solution.
I can complete the PR and add more tests if you are OK with the proposed
solution.
--
Ticket URL: <https://code.djangoproject.com/ticket/31603#comment:1>
Django
Reporter: felixxm | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 3.1
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/12934 New PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/31603#comment:2>
Django
Reporter: felixxm | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 3.1
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/31603#comment:3>
Django
Reporter: felixxm | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"4484bc1b2f84da6442c9c2bfd95d3f1f7d8f96f7" 4484bc1b]:
{{{
#!CommitTicketReference repository=""
revision="4484bc1b2f84da6442c9c2bfd95d3f1f7d8f96f7"
Fixed #31597, #31603 -- Corrected admin clear all filters link behavior.
- Show "Clear all filters" only when any filter is selected.
- Preserve query string not related with filters.
Co-Authored-By: Hasan Ramezani <hasa...@gmail.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31603#comment:4>
Django
Reporter: felixxm | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"47e21d339f91502f414ee2776a72a137e1994072" 47e21d33]:
{{{
#!CommitTicketReference repository=""
revision="47e21d339f91502f414ee2776a72a137e1994072"
[3.1.x] Fixed #31597, #31603 -- Corrected admin clear all filters link
behavior.
- Show "Clear all filters" only when any filter is selected.
- Preserve query string not related with filters.
Co-Authored-By: Hasan Ramezani <hasa...@gmail.com>
Backport of 4484bc1b2f84da6442c9c2bfd95d3f1f7d8f96f7 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31603#comment:5>