[Django] #27098: Deprecate DatabaseIntrospection.get_indexes

40 views
Skip to first unread message

Django

unread,
Aug 20, 2016, 6:13:51 AM8/20/16
to django-...@googlegroups.com
#27098: Deprecate DatabaseIntrospection.get_indexes
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
`DatabaseIntrospection.get_indexes` outputs a subset of
`DatabaseIntrospection.get_constraints`, however only for single-column
indexes. The use case was mainly for `inspectdb` primary key and unique
detections, and for some tests. Now that multicolumn indexes is in sight,
that API is less appealing and appears unnecessary (see also
ticket:16220#comment:19).

--
Ticket URL: <https://code.djangoproject.com/ticket/27098>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 20, 2016, 6:19:13 AM8/20/16
to django-...@googlegroups.com
#27098: Deprecate DatabaseIntrospection.get_indexes
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by claudep):

* needs_better_patch: 0 => 1
* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/7132 WIP PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/27098#comment:1>

Django

unread,
Aug 20, 2016, 8:00:16 AM8/20/16
to django-...@googlegroups.com
#27098: Deprecate DatabaseIntrospection.get_indexes
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: introspection db- | Triage Stage: Accepted
indexes |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by akki):

* keywords: => introspection db-indexes
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/27098#comment:2>

Django

unread,
Aug 30, 2016, 8:50:29 AM8/30/16
to django-...@googlegroups.com
#27098: Deprecate DatabaseIntrospection.get_indexes
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: introspection db- | Triage Stage: Accepted
indexes |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"4c7bf83cde9f698cad019a9b808dbe45a832d9c3" 4c7bf83c]:
{{{
#!CommitTicketReference repository=""
revision="4c7bf83cde9f698cad019a9b808dbe45a832d9c3"
Refs #27097, #27098 -- Moved PostgreSQL index type introspection to
get_constraints().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27098#comment:3>

Django

unread,
Sep 3, 2016, 4:27:56 AM9/3/16
to django-...@googlegroups.com
#27098: Deprecate DatabaseIntrospection.get_indexes
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: introspection db- | Triage Stage: Accepted
indexes |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by claudep):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/27098#comment:4>

Django

unread,
Sep 9, 2016, 10:07:52 AM9/9/16
to django-...@googlegroups.com
#27098: Deprecate DatabaseIntrospection.get_indexes
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: introspection db- | Triage Stage: Ready for
indexes | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/27098#comment:5>

Django

unread,
Sep 12, 2016, 3:29:24 AM9/12/16
to django-...@googlegroups.com
#27098: Deprecate DatabaseIntrospection.get_indexes
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: closed

Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed

Keywords: introspection db- | Triage Stage: Ready for
indexes | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"d389125606152a6cd57d0f6cadeddf0bd6232215" d3891256]:
{{{
#!CommitTicketReference repository=""
revision="d389125606152a6cd57d0f6cadeddf0bd6232215"
Fixed #27098 -- Deprecated DatabaseIntrospection.get_indexes

Thanks Akshesh <akshes...@gmail.com> for help with the PostgreSQL
query.
Thanks Tim Graham for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27098#comment:6>

Django

unread,
Sep 12, 2016, 3:29:25 AM9/12/16
to django-...@googlegroups.com
#27098: Deprecate DatabaseIntrospection.get_indexes
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: introspection db- | Triage Stage: Ready for
indexes | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"a1ad896422437b376462361560086609538779fc" a1ad896]:
{{{
#!CommitTicketReference repository=""
revision="a1ad896422437b376462361560086609538779fc"
Refs #27098 -- Added introspection for expression-based index on
PostgreSQL

Also test it on PostGIS raster fields.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27098#comment:7>

Django

unread,
Sep 22, 2017, 1:39:41 PM9/22/17
to django-...@googlegroups.com
#27098: Deprecate DatabaseIntrospection.get_indexes
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: nobody

Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: introspection db- | Triage Stage: Ready for
indexes | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"578711c31052625cc87319cf1c46662c14d75ce9" 578711c3]:
{{{
#!CommitTicketReference repository=""
revision="578711c31052625cc87319cf1c46662c14d75ce9"
Refs #27098 -- Removed DatabaseIntrospection.get_indexes() per deprecation
timeline.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27098#comment:8>

Django

unread,
May 26, 2018, 10:29:21 AM5/26/18
to django-...@googlegroups.com
#27098: Deprecate DatabaseIntrospection.get_indexes
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: introspection db- | Triage Stage: Ready for
indexes | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"e01fa015c0fca32bb740b575c8fbfd388d8f4957" e01fa015]:
{{{
#!CommitTicketReference repository=""
revision="e01fa015c0fca32bb740b575c8fbfd388d8f4957"
Refs #27098 -- Removed unused introspection queries.

Unused since 578711c31052625cc87319cf1c46662c14d75ce9.

Thanks Ian Foote for finding this.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27098#comment:9>

Django

unread,
May 26, 2018, 10:31:56 AM5/26/18
to django-...@googlegroups.com
#27098: Deprecate DatabaseIntrospection.get_indexes
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: introspection db- | Triage Stage: Ready for
indexes | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"40d87681580ee4f223bcd5ba227ef6ab324a6909" 40d87681]:
{{{
#!CommitTicketReference repository=""
revision="40d87681580ee4f223bcd5ba227ef6ab324a6909"
[2.1.x] Refs #27098 -- Removed unused introspection queries.

Unused since 578711c31052625cc87319cf1c46662c14d75ce9.

Thanks Ian Foote for finding this.

Backport of e01fa015c0fca32bb740b575c8fbfd388d8f4957 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27098#comment:10>

Reply all
Reply to author
Forward
0 new messages