[Django] #28898: autocomplete_fields doesn't support OneToOneField
Django
------------------------------------------+------------------------
Reporter: Lachlan Cannon | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------+------------------------
I'm currently trying to port our projects to Django 2.0, and running into
a problem dropping our old, outdated autocompletes for the new built in
ones, as it appears not to support OneToOne fields.
Looks like the offending line of code is here:
https://github.com/django/django/blob/master/django/contrib/admin/checks.py#L107
--
Ticket URL: <https://code.djangoproject.com/ticket/28898>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
---------------------------------+------------------------------------
Reporter: Lachlan Cannon | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.0
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/28898#comment:1>
Django
Reporter: Lachlan Cannon | Owner: Rodrigo
| Pinheiro Marques de Araújo
Type: Bug | Status: assigned
Component: contrib.admin | Version: 2.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Rodrigo Pinheiro Marques de Araújo):
* status: new => assigned
* owner: nobody => Rodrigo Pinheiro Marques de Araújo
--
Ticket URL: <https://code.djangoproject.com/ticket/28898#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Lachlan Cannon | Owner: Rodrigo
| Pinheiro Marques de Araújo
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Rodrigo Pinheiro Marques de Araújo):
* Attachment "admin-autocomplete-onetoone.patch" added.
Patch - first version
Django
-------------------------------------+-------------------------------------
Reporter: Lachlan Cannon | Owner: Rodrigo
| Pinheiro Marques de Araújo
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Rodrigo Pinheiro Marques de Araújo):
Github pull request https://github.com/django/django/pull/9453
--
Ticket URL: <https://code.djangoproject.com/ticket/28898#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Lachlan Cannon | Owner: Rodrigo
| Pinheiro Marques de Araújo
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Raphael Michel):
For everyone else waiting for this: ``SILENCED_SYSTEM_CHECKS =
['admin.E038']`` is a good-enough workaround for now :)
--
Ticket URL: <https://code.djangoproject.com/ticket/28898#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Lachlan Cannon | Owner: Rodrigo
| Pinheiro Marques de Araújo
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Rodrigo Pinheiro Marques de Araújo):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/28898#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Lachlan Cannon | Owner: Rodrigo
| Pinheiro Marques de Araújo
Component: contrib.admin | Version: 2.0
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"30a389bd7795016d7f48bcda997e5dea5116f9bb" 30a389bd]:
{{{
#!CommitTicketReference repository=""
revision="30a389bd7795016d7f48bcda997e5dea5116f9bb"
Fixed #28898 -- Corrected admin check to allow a OneToOneField in
ModelAdmin.autocomplete_fields.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28898#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Lachlan Cannon | Owner: Rodrigo
| Pinheiro Marques de Araújo
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"9f39f202abea4daf37f4ad3f9e4c272fd9e4d185" 9f39f202]:
{{{
#!CommitTicketReference repository=""
revision="9f39f202abea4daf37f4ad3f9e4c272fd9e4d185"
[2.0.x] Fixed #28898 -- Corrected admin check to allow a OneToOneField in
ModelAdmin.autocomplete_fields.
Backport of 30a389bd7795016d7f48bcda997e5dea5116f9bb from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28898#comment:7>