[Django] #20773: contrib/gis/maps/google/gmap : script() string formating
Django
----------------------------+--------------------
Reporter: martync | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.5
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------+--------------------
The property named "script" in contrib.gis.maps.google.gmap.GoogleMap has
a wrong string formating.
https://github.com/django/django/blob/1.5c2/django/contrib/gis/maps/google/gmap.py#L134-L137
{{{
return format_html('%s\n <script
type="text/javascript">\n//<![CDATA[\n%s//]]>\n </script>',
self.api_script, mark_safe(self.js))
}}}
while it should be :
{{{
return format_html('{0}\n <script
type="text/javascript">\n//<![CDATA[\n{1}//]]>\n </script>',
self.api_script, mark_safe(self.js))
}}}
I have created a pull request for this bug :
https://github.com/django/django/pull/1379
I will write a testcase.
--
Ticket URL: <https://code.djangoproject.com/ticket/20773>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: martync | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.5
Keywords: | Triage Stage: Ready for checkin
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by mjtamlyn):
* needs_better_patch: => 0
* stage: Unreviewed => Ready for checkin
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/20773#comment:1>
Django
Reporter: martync | Owner: nobody
Type: Bug | Status: closed
Component: GIS | Version: 1.5
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for checkin
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz <claude@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"27c1a7257652031d3957c97271723778f27c4d7b"]:
{{{
#!CommitTicketReference repository=""
revision="27c1a7257652031d3957c97271723778f27c4d7b"
Fixed #20773 -- [gis] Fixed regression in GoogleMap output
Thanks Martyn Clement for the report and the initial patch.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20773#comment:2>
Django
Reporter: martync | Owner: nobody
Type: Bug | Status: closed
Component: GIS | Version: 1.5
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for checkin
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"92f66a613498172e6300c8a0b57513183e998597"]:
{{{
#!CommitTicketReference repository=""
revision="92f66a613498172e6300c8a0b57513183e998597"
[1.6.x] Fixed #20773 -- [gis] Fixed regression in GoogleMap output
Thanks Martyn Clement for the report and the initial patch.
Backport of 27c1a7257 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20773#comment:3>
Django
Reporter: martync | Owner: nobody
Type: Bug | Status: closed
Component: GIS | Version: 1.5
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for checkin
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"01910115329c2073e6c68b214155dd5fb87132c8"]:
{{{
#!CommitTicketReference repository=""
revision="01910115329c2073e6c68b214155dd5fb87132c8"
[1.5.x] Fixed #20773 -- [gis] Fixed regression in GoogleMap output
Thanks Martyn Clement for the report and the initial patch.
Backport of 27c1a7257 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20773#comment:4>