[Django] #28465: Unify index SQL creation code

[Django]

#28465: Unify index SQL creation code
-------------------------------------+-------------------------------------
Reporter: Claude | Owner: nobody
Paroz |
Type: | Status: new
Cleanup/optimization |
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Currently, database index creation may happen in two places:
* `Database.SchemaEditor._create_index_sql`
* `Index.create_sql`/`Index.get_sql_create_template_values`

I don't think it's a sane situation. We should decide who's responsible
for index creation code and stick with it.

--
Ticket URL: <https://code.djangoproject.com/ticket/28465>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#28465: Unify index SQL creation code
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Claude Paroz):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/8850 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28465#comment:1>

[Django]

#28465: Unify index SQL creation code
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Simon Charette):

* stage: Unreviewed => Accepted

Comment:

This is something
[https://github.com/django/django/pull/6643#issuecomment-258646571 I
noticed as well] when working on the deferred references stuff for #25530.

Thanks for tackling it Claude!

--
Ticket URL: <https://code.djangoproject.com/ticket/28465#comment:2>

[Django]

#28465: Unify index SQL creation code
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/28465#comment:3>

[Django]

#28465: Unify index SQL creation code
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: nobody

Type: | Status: closed

Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"831358f23d545b8dba017c6b26bd295ba9f6c17d" 831358f]:
{{{
#!CommitTicketReference repository=""
revision="831358f23d545b8dba017c6b26bd295ba9f6c17d"
Fixed #28465 -- Unified index SQL creation in DatabaseSchemaEditor

Thanks Tim Graham for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28465#comment:4>