[Django] #24214: Replace GeoQuerySet custom methods by Expressions/Functions

20 views
Skip to first unread message

Django

unread,
Jan 24, 2015, 7:42:54 AM1/24/15
to django-...@googlegroups.com
#24214: Replace GeoQuerySet custom methods by Expressions/Functions
---------------------------------------+-------------------------
Reporter: claudep | Owner: claudep
Type: New feature | Status: new
Component: GIS | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------+-------------------------
Despite being a little more verbose, the new `Function` API can/should be
now leveraged to replace most if not all of `GeoQuerySet` custom methods.
This will generally simplify the code of the Django GIS module. I'm
currently working on this replacement.

My working branch (frequently rebased):
https://github.com/claudep/django/tree/gis_functions

--
Ticket URL: <https://code.djangoproject.com/ticket/24214>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 31, 2015, 11:47:24 AM1/31/15
to django-...@googlegroups.com
#24214: Replace GeoQuerySet custom methods by Expressions/Functions
-----------------------------+------------------------------------

Reporter: claudep | Owner: claudep
Type: New feature | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-----------------------------+------------------------------------
Changes (by claudep):

* needs_better_patch: 0 => 1
* has_patch: 0 => 1


Comment:

I made some good progress and was able to publish a first pull request:
https://github.com/django/django/pull/4027

The good news is that we might be able to completely remove
GeoQuerySet/GeoManager by Django 2.1!

I still need someone to work on porting the Oracle GIS backend...

--
Ticket URL: <https://code.djangoproject.com/ticket/24214#comment:1>

Django

unread,
Apr 22, 2015, 1:55:52 PM4/22/15
to django-...@googlegroups.com
#24214: Replace GeoQuerySet custom methods by Expressions/Functions
-----------------------------+------------------------------------
Reporter: claudep | Owner: claudep
Type: New feature | Status: closed
Component: GIS | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-----------------------------+------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"d9ff5ef36d3f714736d633435d45f03eac9c17b5" d9ff5ef]:
{{{
#!CommitTicketReference repository=""
revision="d9ff5ef36d3f714736d633435d45f03eac9c17b5"
Fixed #24214 -- Added GIS functions to replace geoqueryset's methods

Thanks Simon Charette and Tim Graham for the reviews.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24214#comment:2>

Reply all
Reply to author
Forward
0 new messages