[Django] #24659: Docs of backends.smtp.EmailBackend: use_tls default should be False, not None

4 views
Skip to first unread message

Django

unread,
Apr 17, 2015, 6:50:17 AM4/17/15
to django-...@googlegroups.com
#24659: Docs of backends.smtp.EmailBackend: use_tls default should be False, not
None
--------------------------------------+--------------------
Reporter: guettli | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
https://docs.djangoproject.com/en/1.8/topics/email/#smtp-backend

I don't understand why the defaults of the constructor are different from
the defaults of the settings:

use_tls=None
use_ssl=None

The defaults of the settings are "False". Which is more intuitive since it
is a boolean (AFAIK).

--
Ticket URL: <https://code.djangoproject.com/ticket/24659>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 17, 2015, 8:11:47 AM4/17/15
to django-...@googlegroups.com
#24659: Docs of backends.smtp.EmailBackend: use_tls default should be False, not
None
--------------------------------------+------------------------------------

Reporter: guettli | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* needs_docs: => 0
* has_patch: 0 => 1
* needs_better_patch: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted


Comment:

Does the attached patch clarify how it works?

--
Ticket URL: <https://code.djangoproject.com/ticket/24659#comment:1>

Django

unread,
Apr 17, 2015, 8:11:54 AM4/17/15
to django-...@googlegroups.com
#24659: Docs of backends.smtp.EmailBackend: use_tls default should be False, not
None
--------------------------------------+------------------------------------

Reporter: guettli | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* Attachment "24659.diff" added.

Django

unread,
Apr 20, 2015, 3:47:02 PM4/20/15
to django-...@googlegroups.com
#24659: Docs of backends.smtp.EmailBackend: use_tls default should be False, not
None
--------------------------------------+------------------------------------
Reporter: guettli | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.8
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"ffe83d16bd0abfa58e4448cf9d48b52cc43544e9" ffe83d16]:
{{{
#!CommitTicketReference repository=""
revision="ffe83d16bd0abfa58e4448cf9d48b52cc43544e9"
Fixed #24659 -- Clarified docs of smtp.EmailBackend parameters.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24659#comment:2>

Django

unread,
Apr 20, 2015, 3:48:13 PM4/20/15
to django-...@googlegroups.com
#24659: Docs of backends.smtp.EmailBackend: use_tls default should be False, not
None
--------------------------------------+------------------------------------
Reporter: guettli | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.8

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"43f800a978deba4bc8d13e7f11e0afdc126cec25" 43f800a9]:
{{{
#!CommitTicketReference repository=""
revision="43f800a978deba4bc8d13e7f11e0afdc126cec25"
[1.8.x] Fixed #24659 -- Clarified docs of smtp.EmailBackend parameters.

Backport of ffe83d16bd0abfa58e4448cf9d48b52cc43544e9 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24659#comment:3>

Reply all
Reply to author
Forward
0 new messages