[Django] #26872: Django Admin filter choice list can overflow the whole page
Django
-------------------------------+--------------------
Reporter: mdamien | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------
In the django admin model listing interface, if the length of a filter
choice is too big, it's gonna overflow the whole page.
[[Image(https://imgur.com/DBCtz6W.png)]]
The solution here can be to do:
{{{
#changelist-filter a {
....
text-overflow: ellipsis;
overflow: hidden;
}
}}}
But the user is loosing the full value, so a `title` should be added too
to the link
--
Ticket URL: <https://code.djangoproject.com/ticket/26872>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: mdamien | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by timgraham):
* needs_better_patch: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/26872#comment:1>
Django
Reporter: mdamien | Owner: kennethyang404
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 1
Changes (by kennethyang404):
* status: new => assigned
* owner: nobody => kennethyang404
--
Ticket URL: <https://code.djangoproject.com/ticket/26872#comment:2>
Django
Reporter: mdamien | Owner: kennethyang404
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by kennethyang404):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/26872#comment:3>
Django
Reporter: mdamien | Owner: kennethyang404
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 1
Changes (by timgraham):
* needs_better_patch: 0 => 1
Comment:
A few test failures need to be fixed.
--
Ticket URL: <https://code.djangoproject.com/ticket/26872#comment:4>
Django
Reporter: mdamien | Owner: kennethyang404
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by kennethyang404):
Sorry this is my first time contributing to Django. Do you think I need to
write a separate test for my patch or just fix the existing ones?
Replying to [comment:4 timgraham]:
> A few test failures need to be fixed.
--
Ticket URL: <https://code.djangoproject.com/ticket/26872#comment:5>
Django
Reporter: mdamien | Owner: kennethyang404
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by timgraham):
Fixing the existing ones should cover the change.
--
Ticket URL: <https://code.djangoproject.com/ticket/26872#comment:6>
Django
Reporter: mdamien | Owner: kennethyang404
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by kennethyang404):
Fixed.
Replying to [comment:6 timgraham]:
> Fixing the existing ones should cover the change.
--
Ticket URL: <https://code.djangoproject.com/ticket/26872#comment:7>
Django
Reporter: mdamien | Owner: kennethyang404
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"2f587737d7acffbd67cb8f427c5fbc5c42ae60c8" 2f587737]:
{{{
#!CommitTicketReference repository=""
revision="2f587737d7acffbd67cb8f427c5fbc5c42ae60c8"
Fixed #26872 -- Fixed text overflow in ModelAdmin.list_filter.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26872#comment:8>
Django
Reporter: mdamien | Owner: kennethyang404
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by mdamien):
Thanks, that was fast ! I was first planning on submitting the PR myself
but it got picked up so quickly :)
--
Ticket URL: <https://code.djangoproject.com/ticket/26872#comment:9>
Django
Reporter: Damien | Owner: Kenneth
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by GitHub <noreply@…>):
In [changeset:"361bb8f786f112ee275be136795c0b1ecefff928" 361bb8f7]:
{{{
#!CommitTicketReference repository=""
revision="361bb8f786f112ee275be136795c0b1ecefff928"
Refs #26872 -- Fixed wrapping of long choices in ModelAdmin.list_filter.
Regression in 269a76714616fd7ad166a14113f3354bab8d9b65.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26872#comment:10>