[Django] #33539: Missing space in SQL generated by PostgresIndex
Django
--------------------------------------------+------------------------
Reporter: Anders Kaseorg | Owner: (none)
Type: Bug | Status: new
Component: contrib.postgres | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
--------------------------------------------+------------------------
If I define an index like
`GinIndex("search_tsvector", fastupdate=False,
name="zerver_message_search_tsvector")`
the following output is generated by `manage.py sqlmigrate`:
`CREATE INDEX "zerver_message_search_tsvector" ON "zerver_message" USING
gin ("search_tsvector")WITH (fastupdate = off) ;`
Note the missing space before `WITH`.
Patch: https://github.com/django/django/pull/15459
--
Ticket URL: <https://code.djangoproject.com/ticket/33539>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Anders Kaseorg | Owner: (none)
Type: Bug | Status: new
Component: contrib.postgres | Version: 3.2
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Description changed by Anders Kaseorg:
Old description:
> If I define an index like
>
> `GinIndex("search_tsvector", fastupdate=False,
> name="zerver_message_search_tsvector")`
>
> the following output is generated by `manage.py sqlmigrate`:
>
> `CREATE INDEX "zerver_message_search_tsvector" ON "zerver_message" USING
> gin ("search_tsvector")WITH (fastupdate = off) ;`
>
> Note the missing space before `WITH`.
>
> Patch: https://github.com/django/django/pull/15459
New description:
If I define an index like
`GinIndex("search_tsvector", fastupdate=False,
name="zerver_message_search_tsvector")`
the following output is generated by `manage.py sqlmigrate`:
`CREATE INDEX "zerver_message_search_tsvector" ON "zerver_message" USING
gin ("search_tsvector")WITH (fastupdate = off) ;`
Note the missing space before `WITH`. It happens that it doesn’t affect
the behavior since it follows `)` (at least in all currently supported
syntaxes), but it should be cleaned up anyway, so I submitted
https://github.com/django/django/pull/15459.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/33539#comment:1>
Django
Reporter: Anders Kaseorg | Owner: (none)
Type: Bug | Status: new
Component: contrib.postgres | Version: 3.2
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Mohamed Nabil Rady):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/33539#comment:2>
Django
Reporter: Anders Kaseorg | Owner: Anders
Type: | Kaseorg
Cleanup/optimization | Status: assigned
Component: contrib.postgres | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Mariusz Felisiak):
* owner: (none) => Anders Kaseorg
* status: new => assigned
* type: Bug => Cleanup/optimization
--
Ticket URL: <https://code.djangoproject.com/ticket/33539#comment:3>
Django
Reporter: Anders Kaseorg | Owner: Anders
Type: | Kaseorg
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Easy pickings: 1 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33539#comment:4>
Django
Reporter: Anders Kaseorg | Owner: Anders
Type: | Kaseorg
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33539#comment:5>
Django
Reporter: Anders Kaseorg | Owner: Anders
Type: | Kaseorg
Component: contrib.postgres | Version: 3.2
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"7f4fc5cbd4c26e137a1abdd9bd603804ddc0e769" 7f4fc5c]:
{{{
#!CommitTicketReference repository=""
revision="7f4fc5cbd4c26e137a1abdd9bd603804ddc0e769"
Fixed #33539 -- Fixed spaces in WITH SQL for indexes on PostgreSQL.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33539#comment:6>