[Django] #30750: Add support for check constraints on MySQL 8.0.16+.
Django
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: nobody
Type: New | Status: new
feature |
Component: Database | Version: master
layer (models, ORM) | Keywords: MySQL, check
Severity: Normal | constraints
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
MySQL 8.0.16+ supports check constraints (see
[https://dev.mysql.com/doc/refman/8.0/en/create-table-check-
constraints.html documentation]), we should support them in Django.
--
Ticket URL: <https://code.djangoproject.com/ticket/30750>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: nobody
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: MySQL, check | Triage Stage: Accepted
constraints |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* Attachment "30750.diff" added.
patch
Django
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: nobody
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: MySQL, check | Triage Stage: Accepted
constraints |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by felixxm):
I've started to work on a patch but still a lot of `schema` tests are
failing on MySQL 8.
--
Ticket URL: <https://code.djangoproject.com/ticket/30750#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: nobody
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: MySQL, check | Triage Stage: Accepted
constraints |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Adam (Chainz) Johnson):
Thanks for making the ticket Mariusz. Yeah MySQL 8 is quite a change.
--
Ticket URL: <https://code.djangoproject.com/ticket/30750#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: nobody
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: MySQL, check | Triage Stage: Accepted
constraints |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Hasan Ramezani):
@felixxm can I continue your work on this ticket?
--
Ticket URL: <https://code.djangoproject.com/ticket/30750#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: nobody
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: MySQL, check | Triage Stage: Accepted
constraints |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by felixxm):
Hasan, sure feel free.
--
Ticket URL: <https://code.djangoproject.com/ticket/30750#comment:4>
Django
-------------------------------------+-------------------------------------
| Ramezani
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: MySQL, check | Triage Stage: Accepted
constraints |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => Hasan Ramezani
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/30750#comment:5>
Django
-------------------------------------+-------------------------------------
| Ramezani
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: MySQL, check | Triage Stage: Accepted
constraints |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
Comment:
@felixxm, I fixed the [https://github.com/django/django/pull/11743/files
#diff-888b45a0a8f38ee67e8d22403cf994dbL1133 test_alter_db_table_case
test].
The problem was that the table belongs to the `Author` model couldn't be
dropped because when the test rename table to the uppercase name, the
`_meta.db_table` has the old name(lowercase name).
So I added another rename to return the table to the original name.
--
Ticket URL: <https://code.djangoproject.com/ticket/30750#comment:6>
Django
-------------------------------------+-------------------------------------
| Ramezani
Component: Database layer | Version: master
(models, ORM) |
Keywords: MySQL, check | Triage Stage: Accepted
constraints |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"e2c6a0858d7d9ad85eda353076a5b46608b704a9" e2c6a08]:
{{{
#!CommitTicketReference repository=""
revision="e2c6a0858d7d9ad85eda353076a5b46608b704a9"
Fixed #30750 -- Added support for check constraints on MySQL 8.0.16+.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30750#comment:7>