[Django] #30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.

17 views
Skip to first unread message

Django

unread,
Sep 24, 2019, 10:20:48 AM9/24/19
to django-...@googlegroups.com
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: nobody
Type: Bug | Status: new
Component: Database | Version: 3.0
layer (models, ORM) |
Severity: Release | Keywords:
blocker |
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
models.E015 is raised when Meta.ordering contains `__pk` of a related
field, e.g.:

{{{
test_app.SomeModel: (models.E015) 'ordering' refers to the nonexistent
field, related field, or lookup 'option__pk'.
}}}

Regression in 440505cb2cadbe1a5b9fba246bcde6c04f51d07e.

--
Ticket URL: <https://code.djangoproject.com/ticket/30798>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 24, 2019, 10:21:23 AM9/24/19
to django-...@googlegroups.com
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 3.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* Attachment "test-30798.diff" added.

Regression test.

Django

unread,
Sep 24, 2019, 5:48:50 PM9/24/19
to django-...@googlegroups.com
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: Hasan
| Ramezani
Type: Bug | Status: assigned

Component: Database layer | Version: 3.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Hasan Ramezani):

* owner: nobody => Hasan Ramezani
* status: new => assigned


Comment:

Thanks @felixxm for the test. I will prepare a fix for it.

--
Ticket URL: <https://code.djangoproject.com/ticket/30798#comment:1>

Django

unread,
Sep 26, 2019, 4:57:26 AM9/26/19
to django-...@googlegroups.com
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: Hasan
| Ramezani
Type: Bug | Status: assigned
Component: Database layer | Version: 3.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Hasan Ramezani):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/30798#comment:2>

Django

unread,
Sep 27, 2019, 8:52:36 AM9/27/19
to django-...@googlegroups.com
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: Hasan
| Ramezani
Type: Bug | Status: assigned
Component: Database layer | Version: 3.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"c7944628a1979453468d67818c63957532d396d8" c7944628]:
{{{
#!CommitTicketReference repository=""
revision="c7944628a1979453468d67818c63957532d396d8"
Refs #30798 -- Prevented chaining fields from the same related model
multiple times in model Meta.ordering.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30798#comment:3>

Django

unread,
Sep 27, 2019, 8:52:36 AM9/27/19
to django-...@googlegroups.com
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: Hasan
| Ramezani
Type: Bug | Status: closed

Component: Database layer | Version: 3.0
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"95a11578ce41de1e152fe7d173f109e280aebd6d" 95a11578]:
{{{
#!CommitTicketReference repository=""
revision="95a11578ce41de1e152fe7d173f109e280aebd6d"
Fixed #30798 -- Fixed Meta.ordering validation for pk of related fields.

Regression in 440505cb2cadbe1a5b9fba246bcde6c04f51d07e.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30798#comment:4>

Django

unread,
Sep 27, 2019, 8:53:27 AM9/27/19
to django-...@googlegroups.com
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: Hasan
| Ramezani
Type: Bug | Status: closed
Component: Database layer | Version: 3.0
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"da8f85aa82a8810cac8c0225c1f8862e5d9aea64" da8f85a]:
{{{
#!CommitTicketReference repository=""
revision="da8f85aa82a8810cac8c0225c1f8862e5d9aea64"
[3.0.x] Refs #30798 -- Prevented chaining fields from the same related


model multiple times in model Meta.ordering.

Backport of c7944628a1979453468d67818c63957532d396d8 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30798#comment:5>

Django

unread,
Sep 27, 2019, 8:53:27 AM9/27/19
to django-...@googlegroups.com
#30798: models.E015 is raised when Meta.ordering contains "pk" of a related field.
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: Hasan
| Ramezani
Type: Bug | Status: closed
Component: Database layer | Version: 3.0
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"0dc39ca8677347ecf25aebd056a130cdbfb8df21" 0dc39ca8]:
{{{
#!CommitTicketReference repository=""
revision="0dc39ca8677347ecf25aebd056a130cdbfb8df21"
[3.0.x] Fixed #30798 -- Fixed Meta.ordering validation for pk of related
fields.

Regression in 440505cb2cadbe1a5b9fba246bcde6c04f51d07e.

Backport of 95a11578ce41de1e152fe7d173f109e280aebd6d from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30798#comment:6>

Reply all
Reply to author
Forward
0 new messages