[Django] #25567: Remove obsolete MEDIA_URL/STATIC_URL compatibility condition

2 views
Skip to first unread message

Django

unread,
Oct 18, 2015, 3:14:20 PM10/18/15
to django-...@googlegroups.com
#25567: Remove obsolete MEDIA_URL/STATIC_URL compatibility condition
------------------------------------------------+------------------------
Reporter: claudep | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
The `absolute_path` method of the forms `Media` class still contains a
compatibility condition that uses `settings.MEDIA_URL` to construct the
path when `settings.STATIC_URL` is not set. This was introduced in Django
1.3 as a backwards compatibility measure when the media/static separation
was introduced.
I think this is now largely obsolete and should be removed.

--
Ticket URL: <https://code.djangoproject.com/ticket/25567>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 19, 2015, 7:52:00 AM10/19/15
to django-...@googlegroups.com
#25567: Remove obsolete MEDIA_URL/STATIC_URL compatibility condition
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* stage: Unreviewed => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/25567#comment:1>

Django

unread,
Oct 19, 2015, 9:40:26 AM10/19/15
to django-...@googlegroups.com
#25567: Remove obsolete MEDIA_URL/STATIC_URL compatibility condition
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Forms | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"f59a0401e5d0e19568a038f2a50954d1a9a1526f" f59a0401]:
{{{
#!CommitTicketReference repository=""
revision="f59a0401e5d0e19568a038f2a50954d1a9a1526f"
Fixed #25567 -- Removed obsolete MEDIA_URL fallback in Media.absolute_path
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25567#comment:2>

Reply all
Reply to author
Forward
0 new messages