[Django] #26651: Keep uploaded file suffix for TemporaryUploadedFile
Django
------------------------------------------------+------------------------
Reporter: claudep | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
I have a use case where checking a temporary uploaded file
(`TemporaryUploadedFile.temporary_file_path()`) includes a check of its
extension. Currently, `TemporaryUploadedFile` always set `.upload` as a
suffix. Would setting the same suffix as the original uploaded file
extension be an issue (security?, compatibility?).
--
Ticket URL: <https://code.djangoproject.com/ticket/26651>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: claudep | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: File | Version: master
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* cc: axiak (added)
* component: Core (Other) => File uploads/storage
Comment:
Michael, it looks like you may have been involved in the original design
of this (ticket:2070#comment:129). Do you have any thoughts?
--
Ticket URL: <https://code.djangoproject.com/ticket/26651#comment:1>
Django
Reporter: claudep | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: File | Version: master
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Unreviewed => Someday/Maybe
--
Ticket URL: <https://code.djangoproject.com/ticket/26651#comment:2>
Django
Reporter: Claude Paroz | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: File | Version: master
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Someday/Maybe
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/8600 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/26651#comment:3>
Django
Reporter: Claude Paroz | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: File | Version: master
uploads/storage |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* stage: Someday/Maybe => Ready for checkin
Comment:
We can give that a try and see if any compatibility issues are reported.
--
Ticket URL: <https://code.djangoproject.com/ticket/26651#comment:4>
Django
Reporter: Claude Paroz | Owner: nobody
Cleanup/optimization |
Component: File | Version: master
uploads/storage |
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz <claude@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"6352d06cd04e151c2ee984eb0bdaa7e8d6824235" 6352d06c]:
{{{
#!CommitTicketReference repository=""
revision="6352d06cd04e151c2ee984eb0bdaa7e8d6824235"
Fixed #26651 -- Kept original file suffix in TemporaryUploadedFile name
Thanks Tim Graham for the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26651#comment:5>