[Django] #23539: GenericInlineModelAdmin doesn't utilize get_extra (and get_max_num/get_min_num)
Django
get_max_num/get_min_num)
-------------------------------+--------------------
Reporter: bigjust | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.7
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
the helper functions get_extra, get_max_num, and get_min_num were
introduced in 1.6 as a way of calculating extra, max_num, min_num per
request. The GenericInlineModelAdmin has continued using the old
self.extra, max_num, and min_num values.
--
Ticket URL: <https://code.djangoproject.com/ticket/23539>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
get_max_num/get_min_num)
Reporter: bigjust | Owner: nobody
Type: Uncategorized | Status: new
contrib.contenttypes | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by bigjust):
* cc: bigjust@… (added)
* needs_better_patch: => 0
* component: Uncategorized => contrib.contenttypes
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/23539#comment:1>
Django
get_max_num/get_min_num)
Reporter: bigjust | Owner: nobody
Type: Uncategorized | Status: new
contrib.contenttypes | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by bigjust):
* has_patch: 0 => 1
Old description:
> the helper functions get_extra, get_max_num, and get_min_num were
> introduced in 1.6 as a way of calculating extra, max_num, min_num per
> request. The GenericInlineModelAdmin has continued using the old
> self.extra, max_num, and min_num values.
New description:
the helper functions get_extra, get_max_num, and get_min_num were
introduced in 1.6 as a way of calculating extra, max_num, min_num per
request. The GenericInlineModelAdmin has continued using the old
self.extra, max_num, and min_num values.
--
Comment:
PR submitted https://github.com/django/django/pull/3263
--
Ticket URL: <https://code.djangoproject.com/ticket/23539#comment:2>
Django
get_max_num/get_min_num)
Reporter: bigjust | Owner: nobody
Type: Bug | Status: new
Component: contrib.contenttypes | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by charettes):
* type: Uncategorized => Bug
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/23539#comment:3>
Django
get_max_num/get_min_num)
Reporter: bigjust | Owner: nobody
Type: Bug | Status: new
Component: contrib.contenttypes | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_tests: 0 => 1
Comment:
Please uncheck "Needs tests" when they are added, thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/23539#comment:4>
Django
get_max_num/get_min_num)
Reporter: bigjust | Owner: nobody
Type: Bug | Status: new
Component: contrib.contenttypes | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by bigjust):
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/23539#comment:5>
Django
get_max_num/get_min_num)
Reporter: bigjust | Owner: nobody
Type: Bug | Status: closed
Component: contrib.contenttypes | Version: 1.7
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"cf43a1ee909ab5dbca5b6a40247cd093a3e2ac8d"]:
{{{
#!CommitTicketReference repository=""
revision="cf43a1ee909ab5dbca5b6a40247cd093a3e2ac8d"
Fixed #23539 -- Added get_extra(), get_max_num(), and get_min_num() hooks
to GenericInlineModelAdmin.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23539#comment:6>
Django
get_max_num/get_min_num)
Reporter: bigjust | Owner: nobody
Type: Bug | Status: closed
Component: contrib.contenttypes | Version: 1.7
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"cc74d8e02e8b659b914859d60002aaa47600f0ff"]:
{{{
#!CommitTicketReference repository=""
revision="cc74d8e02e8b659b914859d60002aaa47600f0ff"
[1.7.x] Fixed #23539 -- Added get_extra(), get_max_num(), and
get_min_num() hooks to GenericInlineModelAdmin.
Backport of cf43a1ee90 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23539#comment:7>