[Django] #33419: forms.Field.help_text shouldn't be HTML-escaped when form rendered with as_ul(), as_p(), as_table() helpers.
Django
as_ul(), as_p(), as_table() helpers.
--------------------------------------------+------------------------
Reporter: Mariusz Felisiak | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 4.0
Severity: Release blocker | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------------+------------------------
`forms.Field.help_text` shouldn't be HTML-escaped (as
[https://docs.djangoproject.com/en/4.0/ref/forms/fields/#help-text
documented]) when form rendered with `as_ul()`, `as_p()`, `as_table()`
helpers.
Thanks Matt Westcott for the [https://groups.google.com/g/django-
developers/c/X7T4VYh3kmw report].
Regression in 456466d932830b096d39806e291fe23ec5ed38d5.
--
Ticket URL: <https://code.djangoproject.com/ticket/33419>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
as_ul(), as_p(), as_table().
----------------------------------+------------------------------------
Reporter: Mariusz Felisiak | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 4.0
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--
Ticket URL: <https://code.djangoproject.com/ticket/33419#comment:1>
Django
as_ul(), as_p(), as_table().
Reporter: Mariusz Felisiak | Owner: David Smith
Type: Bug | Status: assigned
Component: Forms | Version: 4.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by David Smith):
* owner: nobody => David Smith
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/33419#comment:2>
Django
as_ul(), as_p(), as_table().
----------------------------------+---------------------------------------
Reporter: Mariusz Felisiak | Owner: David Smith
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Description changed by Mariusz Felisiak:
Old description:
> `forms.Field.help_text` shouldn't be HTML-escaped (as
> [https://docs.djangoproject.com/en/4.0/ref/forms/fields/#help-text
> documented]) when form rendered with `as_ul()`, `as_p()`, `as_table()`
> helpers.
>
> Thanks Matt Westcott for the [https://groups.google.com/g/django-
> developers/c/X7T4VYh3kmw report].
>
> Regression in 456466d932830b096d39806e291fe23ec5ed38d5.
New description:
`forms.Field.help_text` shouldn't be HTML-escaped (as
[https://docs.djangoproject.com/en/4.0/ref/forms/fields/#help-text
documented]) when form is rendered with `as_ul()`, `as_p()`, `as_table()`
helpers.
Thanks Matt Westcott for the [https://groups.google.com/g/django-
developers/c/X7T4VYh3kmw report].
Regression in 456466d932830b096d39806e291fe23ec5ed38d5.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/33419#comment:3>
Django
as_ul(), as_p(), as_table().
----------------------------------+---------------------------------------
Reporter: Mariusz Felisiak | Owner: David Smith
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by David Smith):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33419#comment:4>
Django
as_ul(), as_p(), as_table().
Reporter: Mariusz Felisiak | Owner: David
| Smith
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33419#comment:5>
Django
as_ul(), as_p(), as_table().
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: David
| Smith
Component: Forms | Version: 4.0
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"4c60c3edff4312303e1021fca47ed52c2152d285" 4c60c3e]:
{{{
#!CommitTicketReference repository=""
revision="4c60c3edff4312303e1021fca47ed52c2152d285"
Fixed #33419 -- Restored marking forms.Field.help_text as HTML safe.
Regression in 456466d932830b096d39806e291fe23ec5ed38d5.
Thanks Matt Westcott for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33419#comment:6>
Django
as_ul(), as_p(), as_table().
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: David
| Smith
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"c959aa99aa365c123a3b5ca72df9d07e0e3fe6e5" c959aa9]:
{{{
#!CommitTicketReference repository=""
revision="c959aa99aa365c123a3b5ca72df9d07e0e3fe6e5"
[4.0.x] Fixed #33419 -- Restored marking forms.Field.help_text as HTML
safe.
Regression in 456466d932830b096d39806e291fe23ec5ed38d5.
Thanks Matt Westcott for the report.
Backport of 4c60c3edff4312303e1021fca47ed52c2152d285 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33419#comment:7>