[Django] #31274: Use signing infrastructure for session data encoding/decoding
Django
------------------------------------------------+------------------------
Reporter: Claude Paroz | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.sessions | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
The signing infrastructure has `dumps` and `loads` utilities to encode and
decode data securely. `SessionBase` should use those instead of handling
hash and encoding itself.
--
Ticket URL: <https://code.djangoproject.com/ticket/31274>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Claude Paroz | Owner: nobody
Cleanup/optimization |
Component: contrib.sessions | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/12460 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/31274#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
Type: | Paroz
Cleanup/optimization | Status: assigned
Component: contrib.sessions | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* owner: nobody => Claude Paroz
* status: new => assigned
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/31274#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
Type: | Paroz
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/31274#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
Type: | Paroz
Component: contrib.sessions | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"d4fff711d4c97356bd6ba1273d2a5e349326eb5f" d4fff711]:
{{{
#!CommitTicketReference repository=""
revision="d4fff711d4c97356bd6ba1273d2a5e349326eb5f"
Fixed #31274 -- Used signing infrastructure in
SessionBase.encode()/decode().
Thanks Mariusz Felisiak and Florian Apolloner for the reviews.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31274#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
Type: | Paroz
Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"8250145a0cbfd15aa16c2ad4e2235d1afe3a7359" 8250145a]:
{{{
#!CommitTicketReference repository=""
revision="8250145a0cbfd15aa16c2ad4e2235d1afe3a7359"
Refs #31274 -- Removed support for the pre-Django 3.1 encoding format of
sessions.
Per deprecation timeline.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31274#comment:5>