[Django] #29612: prefetch_related on GenericRelations not
Django
-------------------------------------+-------------------------------------
Reporter: obayemi | Owner: nobody
Type: Bug | Status: new
Component: Database | Version: 2.0
layer (models, ORM) | Keywords: GenericForeignKey
Severity: Normal | GenericRelation Prefetch
Triage Stage: | prefetch_related
Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
with two models joined with a generic foreignkey / relationship, if we
prefetch the generic relation, its cache will not be invalidated by
updates ({{{.add}}}, {{{.remove}}} nor {{{.all().delete()}}})
{{{
class Foo(models.Model):
tags = GenericRelation("TaggedItem")
class TaggedItem(models.Model):
tag = models.SlugField()
content_type = models.ForeignKey(ContentType,
on_delete=models.CASCADE)
object_id = models.PositiveIntegerField()
content_object = GenericForeignKey("content_type", "object_id")
}}}
{{{
Foo.objects.create()
f = Foo.objects.prefetch_related('tags').last()
a = TaggedItem(tag='tag')
print(f.tags.all())
f.tags.add(a, bulk=False)
print(f.tags.all())
}}}
will give
{{{
<QuerySet []>
<QuerySet []>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29612>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: obayemi | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: prefetch_related | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Simon Charette):
* keywords: GenericForeignKey GenericRelation Prefetch prefetch_related =>
prefetch_related
* version: 2.0 => master
* component: Database layer (models, ORM) => contrib.contenttypes
* stage: Unreviewed => Accepted
Comment:
This is similar to #26706 but for generic relations. The patch can
probably be heavily inspired by d30febb4e59b659e0d279c77f61f936c199a05b2.
--
Ticket URL: <https://code.djangoproject.com/ticket/29612#comment:1>
Django
--------------------------------------+------------------------------------
Reporter: obayemi | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: prefetch_related | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--
Ticket URL: <https://code.djangoproject.com/ticket/29612#comment:2>
Django
--------------------------------------+------------------------------------
Reporter: obayemi | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: prefetch_related | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--
Ticket URL: <https://code.djangoproject.com/ticket/29612#comment:3>
Django
Reporter: obayemi | Owner: Tom
| Forbes
Type: Bug | Status: assigned
Component: | Version: master
contrib.contenttypes |
Severity: Normal | Resolution:
Keywords: prefetch_related | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => Tom Forbes
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/29612#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: obayemi | Owner: Tom
| Forbes
Type: Bug | Status: assigned
Component: | Version: master
contrib.contenttypes |
Severity: Normal | Resolution:
Keywords: prefetch_related | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: Tom Forbes (added)
Comment:
'Heavily inspired' PR: https://github.com/django/django/pull/10277
--
Ticket URL: <https://code.djangoproject.com/ticket/29612#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: obayemi | Owner: Tom
| Forbes
Type: Bug | Status: assigned
Component: | Version: master
contrib.contenttypes |
Severity: Normal | Resolution:
Keywords: prefetch_related | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/29612#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: obayemi | Owner: Tom
| Forbes
Type: Bug | Status: assigned
Component: | Version: master
contrib.contenttypes |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/29612#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: obayemi | Owner: Tom
| Forbes
Component: | Version: master
contrib.contenttypes |
Severity: Normal | Resolution: fixed
Keywords: prefetch_related | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"c02d473781dc2e8699db8edd37cc77f7d43993fc" c02d4737]:
{{{
#!CommitTicketReference repository=""
revision="c02d473781dc2e8699db8edd37cc77f7d43993fc"
Fixed #29612 -- Added GenericRelation prefetch_related() cache
invalidation.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29612#comment:8>