[Django] #19323: Add django.contrib.redirects setting for turning redirect on/off.
Django
-----------------------------------+----------------------------------
Reporter: Melevir | Owner: Melevir
Type: Uncategorized | Status: new
Component: contrib.redirects | Version: 1.4
Severity: Normal | Keywords: redirects, is_active
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-----------------------------------+----------------------------------
At the moment django.contrib.redirects doesn't allow to disable particular
redirect.
To do this I have do remove it completely or rename old_path to
nonexistent. It neither clear nor correct.
Good solution is to add is_active bool field with default=True.
--
Ticket URL: <https://code.djangoproject.com/ticket/19323>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Melevir | Owner: Melevir
Type: New feature | Status: new
Component: contrib.redirects | Version: 1.4
Severity: Normal | Resolution:
Keywords: redirects, | Triage Stage:
is_active | Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by russellm):
* needs_better_patch: => 0
* stage: Unreviewed => Someday/Maybe
* type: Uncategorized => New feature
* needs_tests: => 0
* needs_docs: => 0
Comment:
A reasonable idea, but we're hampered by the lack of a built in schema
migration system.
Marking it someday/maybe; once we have a built-in migration system, this
sort of change will be easy to make, but in the meantime, it's a non-
trivial change.
--
Ticket URL: <https://code.djangoproject.com/ticket/19323#comment:1>
Django
Reporter: Melevir | Owner: Melevir
Type: New feature | Status: new
Component: contrib.redirects | Version: 1.4
Severity: Normal | Resolution:
Keywords: redirects, | Triage Stage:
is_active | Someday/Maybe
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by ZeevG):
Can I assume this feature can be added now that we do have a built-in
migration system?
I'm happy to write a patch, it seems like it might be a good ticket for me
to get started with.
--
Ticket URL: <https://code.djangoproject.com/ticket/19323#comment:2>
Django
Reporter: Melevir | Owner: Melevir
Type: New feature | Status: new
Component: contrib.redirects | Version: 1.4
Severity: Normal | Resolution:
Keywords: schemamigration, | Triage Stage:
redirects, is_active | Someday/Maybe
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by ZeevG):
* keywords: redirects, is_active => schemamigration, redirects, is_active
--
Ticket URL: <https://code.djangoproject.com/ticket/19323#comment:3>
Django
Reporter: Melevir | Owner: Melevir
Type: New feature | Status: new
Component: contrib.redirects | Version: master
Severity: Normal | Resolution:
Keywords: schemamigration, | Triage Stage:
redirects, is_active | Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by timo):
* version: 1.4 => master
* easy: 1 => 0
Comment:
@ZeevG, migrations is still under active development and I don't think
we're quite ready to add them to contrib apps yet. Stay tuned.
--
Ticket URL: <https://code.djangoproject.com/ticket/19323#comment:4>
Django
Reporter: Melevir | Owner: Melevir
Type: New feature | Status: new
Component: contrib.redirects | Version: master
Severity: Normal | Resolution:
Keywords: schemamigration, | Triage Stage:
redirects, is_active | Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by aaugustin):
The current plan is to make changes to models in contrib apps in Django
1.8.
--
Ticket URL: <https://code.djangoproject.com/ticket/19323#comment:5>
Django
Reporter: Melevir | Owner: Melevir
Type: New feature | Status: new
Component: contrib.redirects | Version: master
Severity: Normal | Resolution:
redirects, is_active |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Someday/Maybe => Accepted
Comment:
We'd need to include a documentation warning that since the default
`RedirectFallbackMiddleware.response_redirect_class` is
`HttpResponsePermanentRedirect`, the flag may have no effect on users who
have already accessed the redirect and have it cached by their browser.
--
Ticket URL: <https://code.djangoproject.com/ticket/19323#comment:6>
Django
Reporter: Melevir | Owner: Melevir
Type: New feature | Status: new
Component: contrib.redirects | Version: master
Severity: Normal | Resolution:
Keywords: schemamigration, | Triage Stage: Accepted
redirects, is_active |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: berker.peksag@… (added)
Comment:
Pull request: https://github.com/django/django/pull/5137
--
Ticket URL: <https://code.djangoproject.com/ticket/19323#comment:7>
Django
Reporter: Melevir | Owner: Melevir
Type: New feature | Status: closed
Component: contrib.redirects | Version: master
Severity: Normal | Resolution: wontfix
Keywords: schemamigration, | Triage Stage: Accepted
redirects, is_active |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => wontfix
Comment:
Discussion on the pull request with Berker concluded that adding this
feature would likely be too confusing due to the default redirect being
"permanent".
--
Ticket URL: <https://code.djangoproject.com/ticket/19323#comment:8>