[Django] #26824: MySQL query with CONVERT_TZ is not properly formated
Django
----------------------------------------------+----------------------------
Reporter: truhlik | Owner: nobody
Type: Bug | Status: new
Component: Database layer (models, ORM) | Version: 1.9
Severity: Normal | Keywords: mysql,
| timezone
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------------------+----------------------------
Hi,
I think that there is a bug in ORM if queryset using '__date' and
TIMEZONE.
This code:
{{{
queryset = queryset.filter(created_at__date__lte=created_at_to.date())
}}}
produces this SQL query:
{{{
SELECT ... FROM `payments_payment` WHERE
DATE(CONVERT_TZ(`payments_payment`.`created_at`, 'UTC', Europe/Prague)) <=
2016-06-30)
}}}
The problem is that 'Europe/Prague' is not in the quotes! Mysql returns
this error:
{{{
#1054 - Unknown column 'Europe' in 'where clause'
}}}
my settings.py
{{{
TIME_ZONE = "Europe/Prague"
DATABASES = {
'default': {
'ENGINE': 'django.db.backends.mysql',
'NAME': 'reality_15062016',
'PORT': '3306',
'TIME_ZONE': 'Europe/Prague',
'OPTIONS': {
'charset': 'utf8',
'use_unicode': True,
}
}
}
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26824>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: truhlik | Owner: nobody
Type: Bug | Status: new
(models, ORM) |
Severity: Normal | Resolution:
Keywords: mysql, timezone | Triage Stage:
| Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
Can you try to construct a test for Django's test suite? A found
[https://github.com/django/django/blob/12b4280444b58c94197255655e284e4103fe00a9/tests/model_fields/test_datetimefield.py#L50-L70
a similar one] which generates this query:
{{{ #!sql
SELECT `model_fields_datetimemodel`.`id`,
`model_fields_datetimemodel`.`d`, `model_fields_datetimemodel`.`dt`,
`model_fields_datetimemodel`.`t`
FROM `model_fields_datetimemodel`
WHERE DATE(CONVERT_TZ(`model_fields_datetimemodel`.`dt`, 'UTC',
America/Vancouver)) = 2014-03-12
}}}
Does it pass for you? Which version of MySQL are you using?
Did you load the [https://docs.djangoproject.com/en/stable/ref/databases
/#time-zone-definitions MySQL timezone definitions]?
--
Ticket URL: <https://code.djangoproject.com/ticket/26824#comment:1>
Django
Reporter: truhlik | Owner: nobody
Type: Bug | Status: new
(models, ORM) |
Severity: Normal | Resolution:
| Unreviewed
Easy pickings: 0 | UI/UX: 0
Comment (by truhlik):
Using Mysql: 5.5.49-0+deb8u1 - (Debian)
MySQL timezone definitions have been loaded properly.
Strange behavior. I pass all 6 tests in the suite, which you point. But
when I try the single SQL query, the Error appears.
I modified the code a little to see the query which Django produce.
{{{
...
with self.settings(TIME_ZONE='UTC'):
# But in UTC, the __date only matches one of them.
q = DateTimeModel.objects.filter(dt__date=d)
print q.query
self.assertQuerysetEqual(DateTimeModel.objects.filter(dt__date=d),
[repr(m1)])
}}}
and the output is this:
{{{
Using existing test database for alias 'default'...
.sSELECT `payments_datetimemodel`.`id`, `payments_datetimemodel`.`d`,
`payments_datetimemodel`.`dt`, `payments_datetimemodel`.`t` FROM
`payments_datetimemodel` WHERE
DATE(CONVERT_TZ(`payments_datetimemodel`.`dt`, 'UTC', UTC)) = 2014-03-12
....
----------------------------------------------------------------------
Ran 6 tests in 0.734s
OK (skipped=1)
}}}
Then trying to use the same query (without quotes) directly in mysql
client.
{{{
mysql> SELECT `payments_datetimemodel`.`id`, `payments_datetimemodel`.`d`,
`payments_datetimemodel`.`dt`, `payments_datetimemodel`.`t` FROM
`payments_datetimemodel` WHERE
DATE(CONVERT_TZ(`payments_datetimemodel`.`dt`, 'UTC', UTC)) = 2014-03-12;
ERROR 1054 (42S22): Unknown column 'UTC' in 'where clause'
}}}
and with quotes:
{{{
mysql> SELECT `payments_datetimemodel`.`id`, `payments_datetimemodel`.`d`,
`payments_datetimemodel`.`dt`, `payments_datetimemodel`.`t` FROM
`payments_datetimemodel` WHERE
DATE(CONVERT_TZ(`payments_datetimemodel`.`dt`, 'UTC', 'UTC')) =
2014-03-12;
Empty set (0.00 sec)
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26824#comment:2>
Django
Reporter: truhlik | Owner: nobody
Type: Bug | Status: new
(models, ORM) |
Severity: Normal | Resolution:
| Unreviewed
Easy pickings: 0 | UI/UX: 0
Comment (by timgraham):
`str(queryset.query)` returns a representation of the query, not
necessarily one that can be executed. Is that the issue in the original
report?
--
Ticket URL: <https://code.djangoproject.com/ticket/26824#comment:3>
Django
Reporter: truhlik | Owner: nobody
Type: Bug | Status: closed
Component: Database layer | Version: 1.9
(models, ORM) |
Keywords: mysql, timezone | Triage Stage:
| Unreviewed
Easy pickings: 0 | UI/UX: 0
Changes (by charettes):
* status: new => closed
* resolution: => needsinfo
--
Ticket URL: <https://code.djangoproject.com/ticket/26824#comment:4>
Django
Reporter: truhlik | Owner: nobody
Type: Bug | Status: closed
Component: Database layer | Version: 1.9
(models, ORM) |
Severity: Normal | Resolution: needsinfo
| Unreviewed
Easy pickings: 0 | UI/UX: 0
Comment (by truhlik):
No, it's not the issue, which I wan't to report. My issue is that the
'_date' filter is not working correctly in my configuration.
Replying to [comment:3 timgraham]:
> `str(queryset.query)` returns a representation of the query, not
necessarily one that can be executed. Is that the issue in the original
report?
--
Ticket URL: <https://code.djangoproject.com/ticket/26824#comment:5>
Django
Reporter: truhlik | Owner: nobody
Type: Bug | Status: closed
Component: Database layer | Version: 1.9
(models, ORM) |
Severity: Normal | Resolution: needsinfo
| Unreviewed
Easy pickings: 0 | UI/UX: 0
Comment (by charettes):
What did you use to print the query you pasted into the mysql client?
--
Ticket URL: <https://code.djangoproject.com/ticket/26824#comment:6>
Django
Reporter: truhlik | Owner: nobody
Type: Bug | Status: closed
Component: Database layer | Version: 1.9
(models, ORM) |
Severity: Normal | Resolution: needsinfo
| Unreviewed
Easy pickings: 0 | UI/UX: 0
Comment (by truhlik):
{{{
queryset =
Payments.objects.filter(created_at__date__lte=created_at_to.date())
print queryset.query
}}}
Replying to [comment:6 charettes]:
> What did you use to print the query you pasted into the mysql client?
--
Ticket URL: <https://code.djangoproject.com/ticket/26824#comment:7>
Django
Reporter: truhlik | Owner: nobody
Type: Bug | Status: closed
Component: Database layer | Version: 1.9
(models, ORM) |
Keywords: mysql, timezone | Triage Stage:
| Unreviewed
Easy pickings: 0 | UI/UX: 0
Changes (by charettes):
* resolution: needsinfo => invalid
Comment:
As mentioned by Tim above `str(queryset.query)` returns
[https://github.com/django/django/blob/6d61ec0e1a4eb5768be5add9e1c44c89dacbfa7e/django/db/models/sql/query.py#L95-L96
a representation of the query] and not what is actually executed as the
escaping part is left to the backend which escapes parameters such as the
timezone name.
Please re-open if you can provide an actual failing testcase or at least a
traceback that does not rely on executing a representation of
`Queryset.query`.
--
Ticket URL: <https://code.djangoproject.com/ticket/26824#comment:8>