[Django] #26897: makemessages crash with non ascii file names

37 views
Skip to first unread message

Django

unread,
Jul 14, 2016, 12:23:50 PM7/14/16
to django-...@googlegroups.com
#26897: makemessages crash with non ascii file names
------------------------------------------------+-------------------------
Reporter: claudep | Owner: claudep
Type: Bug | Status: new
Component: Internationalization | Version: 1.9
Severity: Release blocker | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+-------------------------
On Python 2:
{{{
...
File "/home/claude/virtualenvs/djangogit/local/lib/python2.7/site-
packages/django/core/management/commands/makemessages.py", line 393, in
build_potfiles
self.process_files(file_list)
File "/home/claude/virtualenvs/djangogit/local/lib/python2.7/site-
packages/django/core/management/commands/makemessages.py", line 488, in
process_files
self.process_locale_dir(locale_dir, files)
File "/home/claude/virtualenvs/djangogit/local/lib/python2.7/site-
packages/django/core/management/commands/makemessages.py", line 552, in
process_locale_dir
input_files_list.write('\n'.join(input_files))
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in
position 233: ordinal not in range(128)
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26897>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 14, 2016, 12:26:38 PM7/14/16
to django-...@googlegroups.com
#26897: makemessages crash with non ascii file names
--------------------------------------+------------------------------------

Reporter: claudep | Owner: claudep
Type: Bug | Status: new
Component: Internationalization | Version: 1.9
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by claudep):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/6915 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/26897#comment:1>

Django

unread,
Jul 14, 2016, 2:13:59 PM7/14/16
to django-...@googlegroups.com
#26897: makemessages crash with non ascii file names
-------------------------------------+-------------------------------------

Reporter: claudep | Owner: claudep
Type: Bug | Status: new
Component: | Version: 1.9
Internationalization |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/26897#comment:2>

Django

unread,
Jul 14, 2016, 2:38:36 PM7/14/16
to django-...@googlegroups.com
#26897: makemessages crash with non ascii file names
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: claudep
Type: Bug | Status: closed
Component: | Version: 1.9
Internationalization |
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"3e71f6544feca490211e88db4f449dfdb7acce39" 3e71f654]:
{{{
#!CommitTicketReference repository=""
revision="3e71f6544feca490211e88db4f449dfdb7acce39"
Fixed #26897 -- Fixed makemessages crash on Python 2 with non-ASCII file
names

Thanks Tim Graham for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26897#comment:3>

Django

unread,
Jul 14, 2016, 2:39:47 PM7/14/16
to django-...@googlegroups.com
#26897: makemessages crash with non ascii file names
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: claudep

Type: Bug | Status: closed
Component: | Version: 1.9
Internationalization |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"96a37a0266b3bf46491cc764e4096cc3bfeda6b3" 96a37a02]:
{{{
#!CommitTicketReference repository=""
revision="96a37a0266b3bf46491cc764e4096cc3bfeda6b3"
[1.10.x] Fixed #26897 -- Fixed makemessages crash on Python 2 with non-
ASCII file names

Thanks Tim Graham for the review.

Backport of 3e71f6544feca490211e88db4f449dfdb7acce39 from master.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26897#comment:4>

Django

unread,
Jul 14, 2016, 2:40:40 PM7/14/16
to django-...@googlegroups.com
#26897: makemessages crash with non ascii file names
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: claudep

Type: Bug | Status: closed
Component: | Version: 1.9
Internationalization |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"a74adb4c35a90f41e56bb97166a784e56835a56a" a74adb4c]:
{{{
#!CommitTicketReference repository=""
revision="a74adb4c35a90f41e56bb97166a784e56835a56a"
[1.9.x] Fixed #26897 -- Fixed makemessages crash on Python 2 with non-
ASCII file names

Thanks Tim Graham for the review.
Backport of 3e71f6544feca490211e88db4f449dfdb7acce39 from master.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26897#comment:5>

Django

unread,
Jul 14, 2016, 3:45:27 PM7/14/16
to django-...@googlegroups.com
#26897: makemessages crash with non ascii file names
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: claudep

Type: Bug | Status: closed
Component: | Version: 1.9
Internationalization |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"208eead7874ef19b2a72ecf442eb4a5067cc8d7d" 208eead7]:
{{{
#!CommitTicketReference repository=""
revision="208eead7874ef19b2a72ecf442eb4a5067cc8d7d"
[1.10.x] Refs #26897 -- Missing directory containment in i18n test
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26897#comment:6>

Django

unread,
Jul 14, 2016, 3:46:16 PM7/14/16
to django-...@googlegroups.com
#26897: makemessages crash with non ascii file names
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: claudep

Type: Bug | Status: closed
Component: | Version: 1.9
Internationalization |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"e1a60f2ecbc9311744a42e5a7247fd4e8e2a6f91" e1a60f2e]:
{{{
#!CommitTicketReference repository=""
revision="e1a60f2ecbc9311744a42e5a7247fd4e8e2a6f91"
[1.9.x] Refs #26897 -- Missing directory containment in i18n test
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26897#comment:7>

Django

unread,
Jul 14, 2016, 4:40:39 PM7/14/16
to django-...@googlegroups.com
#26897: makemessages crash with non ascii file names
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: claudep

Type: Bug | Status: closed
Component: | Version: 1.9
Internationalization |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"de9af3912c766a1ebef1e95bc11076faa831e944" de9af391]:
{{{
#!CommitTicketReference repository=""
revision="de9af3912c766a1ebef1e95bc11076faa831e944"
[1.10.x] Refs #26897 -- Added cleanup to i18n test
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26897#comment:8>

Django

unread,
Jul 14, 2016, 4:41:15 PM7/14/16
to django-...@googlegroups.com
#26897: makemessages crash with non ascii file names
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: claudep

Type: Bug | Status: closed
Component: | Version: 1.9
Internationalization |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"ab2f5f764a2f6db97e23cccd5c4f5abbb43d1caf" ab2f5f76]:
{{{
#!CommitTicketReference repository=""
revision="ab2f5f764a2f6db97e23cccd5c4f5abbb43d1caf"
[1.9.x] Refs #26897 -- Added cleanup to i18n test
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26897#comment:9>

Reply all
Reply to author
Forward
0 new messages