[Django] #24716: Deprecate Field._get_val_from_obj

[Django]

#24716: Deprecate Field._get_val_from_obj
----------------------------------------------+-----------------------
Reporter: ovangle | Owner: ovangle@…
Type: Uncategorized | Status: new
Component: Database layer (models, ORM) | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
----------------------------------------------+-----------------------
Redundant method, called only by `Field.value_to_string`.

--
Ticket URL: <https://code.djangoproject.com/ticket/24716>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#24716: Deprecate Field._get_val_from_obj
-------------------------------------+-------------------------------------
Reporter: ovangle | Owner: ovangle
Type: Uncategorized | Status: assigned
Component: Database layer | Version: 1.8
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by ovangle):

* status: new => assigned
* needs_better_patch: => 0
* owner: ovangle@… => ovangle
* needs_tests: => 0
* needs_docs: => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/24716#comment:1>

[Django]

#24716: Deprecate Field._get_val_from_obj
-------------------------------------+-------------------------------------
Reporter: ovangle | Owner: ovangle

Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: master

(models, ORM) |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* has_patch: 0 => 1
* version: 1.8 => master
* type: Uncategorized => Cleanup/optimization
* easy: 1 => 0
* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/24716#comment:2>

[Django]

#24716: Deprecate Field._get_val_from_obj
-------------------------------------+-------------------------------------
Reporter: ovangle | Owner: ovangle
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/24716#comment:3>

[Django]

#24716: Deprecate Field._get_val_from_obj
-------------------------------------+-------------------------------------
Reporter: ovangle | Owner: ovangle
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 1 => 0

Comment:

[https://github.com/django/django/pull/4961 Updated PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/24716#comment:4>

[Django]

#24716: Deprecate Field._get_val_from_obj
-------------------------------------+-------------------------------------
Reporter: ovangle | Owner: ovangle

Type: | Status: closed

Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"035b0fa60da2e758d0ab7f9d04ef93cdb73c981f" 035b0fa]:
{{{
#!CommitTicketReference repository=""
revision="035b0fa60da2e758d0ab7f9d04ef93cdb73c981f"
Fixed #24716 -- Deprecated Field._get_val_from_obj()

The method duplicates the functionality of Field.value_from_object()
and has the additional downside of being a privately named public
API method.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24716#comment:5>

[Django]

#24716: Deprecate Field._get_val_from_obj
-------------------------------------+-------------------------------------
Reporter: Thomas Stephenson | Owner: Thomas
Type: | Stephenson
Cleanup/optimization | Status: closed

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"733c7c703030d2546b729dfa20edfa5217d1da20" 733c7c7]:
{{{
#!CommitTicketReference repository=""
revision="733c7c703030d2546b729dfa20edfa5217d1da20"
Refs #24716 -- Removed Field._get_val_from_obj() per deprecation timeline.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24716#comment:6>