[Django] #28184: FileField storages param should allow a callable
Django
-------------------------------------+-------------------------------------
Reporter: miigotu | Owner: miigotu
Type: New | Status: assigned
feature |
Component: File | Version: 1.11
uploads/storage | Keywords: callable storage
Severity: Normal | filefield
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
For example, when using S3 I may have a field that I want to use private
acl, while other fields are not using private storage. Locally or in
different deployments I may not be using S3, and the storage is different.
--
Ticket URL: <https://code.djangoproject.com/ticket/28184>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: miigotu | Owner: miigotu
Component: File | Version: 1.11
uploads/storage |
Keywords: callable storage | Triage Stage: Accepted
filefield |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):
* needs_better_patch: 0 => 1
* easy: 1 => 0
* stage: Unreviewed => Accepted
Comment:
Tentatively accepting. This idea also came up in #24648. The PR has test
failures and documentation changes are also required. See the
PatchReviewChecklist.
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: miigotu | Owner: miigotu
Component: File | Version: 1.11
uploads/storage |
Keywords: callable storage | Triage Stage: Accepted
filefield |
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
Comment:
Improved patch, passes all tests now.
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: miigotu | Owner: miigotu
Component: File | Version: 1.11
uploads/storage |
Keywords: callable storage | Triage Stage: Accepted
filefield |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* needs_docs: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: miigotu | Owner: miigotu
Component: File | Version: 1.11
uploads/storage |
Keywords: callable storage | Triage Stage: Accepted
filefield |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson):
Left some comments on PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: miigotu | Owner: miigotu
Component: File | Version: 1.11
uploads/storage |
Keywords: callable storage | Triage Stage: Accepted
filefield |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by miigotu):
Replying to [comment:4 Carlton Gibson]:
> Left some comments on PR.
PR Updated, please review
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: miigotu | Owner: miigotu
Component: File | Version: 1.11
uploads/storage |
Keywords: callable storage | Triage Stage: Accepted
filefield |
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
* needs_docs: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: miigotu | Owner: miigotu
uploads/storage |
Severity: Normal | Resolution:
Keywords: callable storage | Triage Stage: Accepted
filefield |
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by miigotu):
* version: 1.11 => master
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: miigotu | Owner: miigotu
Component: File | Version: master
uploads/storage |
Severity: Normal | Resolution:
Keywords: callable storage | Triage Stage: Accepted
filefield |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: miigotu | Owner: miigotu
Component: File | Version: master
uploads/storage |
Severity: Normal | Resolution:
Keywords: callable storage | Triage Stage: Accepted
filefield |
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: miigotu | Owner: miigotu
Component: File | Version: master
uploads/storage |
Severity: Normal | Resolution:
filefield | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: miigotu | Owner: miigotu
Component: File | Version: master
uploads/storage |
Keywords: callable storage | Triage Stage: Ready for
filefield | checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson <carlton@…>):
In [changeset:"94b32a20ef798768029651f0e8fcc07731a62a64" 94b32a2]:
{{{
#!CommitTicketReference repository=""
revision="94b32a20ef798768029651f0e8fcc07731a62a64"
Refs #28184 -- Added test for FileField storage default.
Co-authored-by: miigotu <mii...@gmail.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: miigotu | Owner: miigotu
Component: File | Version: master
uploads/storage |
Severity: Normal | Resolution: fixed
Keywords: callable storage | Triage Stage: Ready for
filefield | checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"210657b791fec359a9109b69e566018253edfad0" 210657b7]:
{{{
#!CommitTicketReference repository=""
revision="210657b791fec359a9109b69e566018253edfad0"
Fixed #28184 -- Allowed using a callable for FileField and ImageField
storage.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:11>