[Django] #28206: Raw queries with Oracle impossible when using uppercase column names

9 views
Skip to first unread message

Django

unread,
May 14, 2017, 9:04:45 AM5/14/17
to django-...@googlegroups.com
#28206: Raw queries with Oracle impossible when using uppercase column names
-------------------------------------+-------------------------------------
Reporter: mitya57 | Owner: nobody
Type: Bug | Status: new
Component: Database | Version: 1.11
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
When one has a model with a custom column name in uppercase, say:

{{{
class Man(Model):
id = models.AutoField(primary_key=True, db_column="F_MAN_ID")
}}}

Then it is impossible to use RawQuerySets with this model on Oracle, you
will always get the “InvalidQuery: Raw query must include the primary key”
error.

The problem is that {{{column_name_converter()}}} converts the column
names to lowercase, so even if you use {{{F_MAN_ID}}} in your query, the
{{{self.columns}}} list in the RawQuerySet instance will contain the
lowercase column name. And because of case differences the {{{f.column in
self.columns}}} check in {{{resolve_model_init_order}}} method will return
False.

We are currently using Django 1.8 in production, but I looked at the
Django code and it’s the same between 1.8 and 1.11, so I have put 1.11
into the Version field.

--
Ticket URL: <https://code.djangoproject.com/ticket/28206>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 15, 2017, 8:32:33 AM5/15/17
to django-...@googlegroups.com
#28206: Raw queries with Oracle impossible when using uppercase column names
-------------------------------------+-------------------------------------
Reporter: Dmitry Shachnev | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 1.11
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* Attachment "28206.diff" added.

Test

Django

unread,
May 15, 2017, 8:33:26 AM5/15/17
to django-...@googlegroups.com
#28206: Raw queries with Oracle impossible when using uppercase column names
-------------------------------------+-------------------------------------
Reporter: Dmitry Shachnev | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: master

(models, ORM) |
Severity: Normal | Resolution:
Keywords: Oracle | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* keywords: => Oracle
* version: 1.11 => master
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/28206#comment:1>

Django

unread,
May 16, 2017, 2:24:39 PM5/16/17
to django-...@googlegroups.com
#28206: Raw queries with Oracle impossible when using uppercase column names
-------------------------------------+-------------------------------------
Reporter: Dmitry Shachnev | Owner: felixxm
Type: Bug | Status: assigned

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: Oracle | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* status: new => assigned
* owner: nobody => felixxm


--
Ticket URL: <https://code.djangoproject.com/ticket/28206#comment:2>

Django

unread,
May 16, 2017, 3:16:50 PM5/16/17
to django-...@googlegroups.com
#28206: Raw queries with Oracle impossible when using uppercase column names
-------------------------------------+-------------------------------------
Reporter: Dmitry Shachnev | Owner: felixxm
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: Oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/8511 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28206#comment:3>

Django

unread,
May 18, 2017, 10:45:59 AM5/18/17
to django-...@googlegroups.com
#28206: Raw queries with Oracle impossible when using uppercase column names
-------------------------------------+-------------------------------------
Reporter: Dmitry Shachnev | Owner: felixxm
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: Oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/28206#comment:4>

Django

unread,
May 18, 2017, 1:11:46 PM5/18/17
to django-...@googlegroups.com
#28206: Raw queries with Oracle impossible when using uppercase column names
-------------------------------------+-------------------------------------
Reporter: Dmitry Shachnev | Owner: felixxm
Type: Bug | Status: closed

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed

Keywords: Oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"99df304c856ac2f6ee18418ea8ca3e2dc7b47dac" 99df304]:
{{{
#!CommitTicketReference repository=""
revision="99df304c856ac2f6ee18418ea8ca3e2dc7b47dac"
Fixed #28206 -- Fixed RawQuerySet crash on a model with a mixed case
db_column pk on Oracle.

Thanks Tim Graham for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28206#comment:5>

Reply all
Reply to author
Forward
0 new messages